Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm

Issue 2894553003: Add |web_usage_enabled| to DeserializeWebStateList() (Closed)
Patch Set: Test web_usage_enabled bool Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/web_state_list/web_state_list_serialization.h" 5 #import "ios/chrome/browser/web_state_list/web_state_list_serialization.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 original_web_state_list.SetOpenerOfWebStateAt( 117 original_web_state_list.SetOpenerOfWebStateAt(
118 3, WebStateOpener(original_web_state_list.GetWebStateAt(1), 1)); 118 3, WebStateOpener(original_web_state_list.GetWebStateAt(1), 1));
119 original_web_state_list.ActivateWebStateAt(1); 119 original_web_state_list.ActivateWebStateAt(1);
120 120
121 SessionWindowIOS* session_window = 121 SessionWindowIOS* session_window =
122 SerializeWebStateList(&original_web_state_list); 122 SerializeWebStateList(&original_web_state_list);
123 123
124 EXPECT_EQ(4u, session_window.sessions.count); 124 EXPECT_EQ(4u, session_window.sessions.count);
125 EXPECT_EQ(1u, session_window.selectedIndex); 125 EXPECT_EQ(1u, session_window.selectedIndex);
126 126
127 // Create a deserialized WebStateList and verify its contents.
127 WebStateList restored_web_state_list(web_state_list_delegate()); 128 WebStateList restored_web_state_list(web_state_list_delegate());
128 restored_web_state_list.InsertWebState(0, SerializableTestWebState::Create()); 129 restored_web_state_list.InsertWebState(0, SerializableTestWebState::Create());
129 ASSERT_EQ(1, restored_web_state_list.count()); 130 ASSERT_EQ(1, restored_web_state_list.count());
130 131
131 DeserializeWebStateList( 132 DeserializeWebStateList(
132 &restored_web_state_list, session_window, 133 &restored_web_state_list, session_window, false,
133 base::BindRepeating(&SerializableTestWebState::CreateWithSessionStorage)); 134 base::BindRepeating(&SerializableTestWebState::CreateWithSessionStorage));
134 135
135 EXPECT_EQ(5, restored_web_state_list.count()); 136 EXPECT_EQ(5, restored_web_state_list.count());
136 EXPECT_EQ(2, restored_web_state_list.active_index()); 137 EXPECT_EQ(2, restored_web_state_list.active_index());
137 ExpectRelationshipIdenticalFrom(1, &original_web_state_list, 138 ExpectRelationshipIdenticalFrom(1, &original_web_state_list,
138 &restored_web_state_list); 139 &restored_web_state_list);
140
141 // Create a deserialized WebStateList with web usage enabled and verify its
142 // contents.
143 WebStateList restored_web_state_list_web_usage_enabled(
144 web_state_list_delegate());
145 std::unique_ptr<web::WebState> webUsageEnabledWebState =
146 SerializableTestWebState::Create();
147 webUsageEnabledWebState->SetWebUsageEnabled(true);
148 restored_web_state_list_web_usage_enabled.InsertWebState(
149 0, std::move(webUsageEnabledWebState));
150 ASSERT_EQ(1, restored_web_state_list_web_usage_enabled.count());
151
152 DeserializeWebStateList(
153 &restored_web_state_list_web_usage_enabled, session_window, true,
154 base::BindRepeating(&SerializableTestWebState::CreateWithSessionStorage));
155
156 EXPECT_EQ(5, restored_web_state_list_web_usage_enabled.count());
157 EXPECT_EQ(2, restored_web_state_list_web_usage_enabled.active_index());
158 ExpectRelationshipIdenticalFrom(1, &original_web_state_list,
159 &restored_web_state_list_web_usage_enabled);
160
161 // Verify that the WebUsageEnabled bit is set appropriately for the restored
162 // WebStateLists.
Eugene But (OOO till 7-30) 2017/05/19 14:18:05 ASSERT_EQ(restored_web_state_list_web_usage_enable
kkhorimoto 2017/05/19 17:58:16 Done.
163 for (int i = 0; i < 5; ++i) {
Eugene But (OOO till 7-30) 2017/05/19 14:18:05 s/5/restored_web_state_list_web_usage_enabled.coun
kkhorimoto 2017/05/19 17:58:16 Done.
164 EXPECT_TRUE(restored_web_state_list_web_usage_enabled.GetWebStateAt(i)
165 ->IsWebUsageEnabled());
166 EXPECT_FALSE(restored_web_state_list.GetWebStateAt(i)->IsWebUsageEnabled());
167 }
139 } 168 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698