Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2894483002: Migrate from ScopedComPtr::CreateInstance() to CoCreateInstance in chrome/... (Closed)

Created:
3 years, 7 months ago by robliao
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang, scottmg
CC:
chromium-reviews, David Trainor- moved to gerrit, tzik, Lei Zhang, tfarina, nhiroki, wfh+watch_chromium.org, tommycli, pennymac+watch_chromium.org, asvitkine+watch_chromium.org, grt+watch_chromium.org, kinuko+fileapi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate from ScopedComPtr::CreateInstance() to CoCreateInstance in chrome/... ScopedComPtr::CreateInstance() will soon be removed in favor of directly calling CoCreateInstance(). This change is a mechanical refactor from ScopedComPtr::CreateInstance() to CoCreateInstance(). BUG=638327 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2894483002 Cr-Commit-Position: refs/heads/master@{#472710} Committed: https://chromium.googlesource.com/chromium/src/+/a872e99f20ad4d94d954241b6583aa98a46ee4de

Patch Set 1 #

Patch Set 2 : Fix Header Include Location #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -60 lines) Patch
M chrome/browser/download/download_status_updater_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_win.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/av_scanning_file_validator.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_operations_util.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/metrics/antivirus_metrics_provider_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/speech/tts_win.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/taskbar_decorator_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_win.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/win/jumplist_updater.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/win/settings_app_monitor.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/installer/gcapi/gcapi.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/advanced_firewall_manager_win.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/installer/util/legacy_firewall_manager_win.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 6 chunks +13 lines, -9 lines 0 comments Download
M chrome/installer/util/wmi.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/utility/shell_handler_impl_win.cc View 2 chunks +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (19 generated)
robliao
scottmg: Please review this change. Thanks!
3 years, 7 months ago (2017-05-17 21:26:50 UTC) #6
Lei Zhang
chrome/OWNERS lgtm, with scottmg's approval.
3 years, 7 months ago (2017-05-17 21:29:14 UTC) #8
scottmg
lgtm
3 years, 7 months ago (2017-05-17 22:58:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894483002/20001
3 years, 7 months ago (2017-05-18 00:53:56 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 06:36:39 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a872e99f20ad4d94d954241b6583...

Powered by Google App Engine
This is Rietveld 408576698