Remove ScopedComPtr::CreateInstance()

Remove ScopedComPtr::CreateInstance()

This is better expressed as directly calling CoCreateInstance().

This change is a mechanical refactor from
ScopedComPtr::CreateInstance() to CoCreateInstance().

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, jam@chromium.org, reillyg@chromium.org, rsleevi@chromium.org, sdefresne@chromium.org, thakis@chromium.org, nicholss@chromium.org, 
Mechanical refactor.

Review-Url: https://codereview.chromium.org/2887243002
Cr-Commit-Position: refs/heads/master@{#472858}
Committed: https://chromium.googlesource.com/chromium/src/+/eb9bfd648536ce835bb62026506bd29395de3f88

[robliao, 2017-05-17 22:02:42]

Description was changed from

==========
Remove ScopedComPtr::CreateInstance()

This is better expressed as directly calling CoCreateInstance().

This change is a mechanical refactor from
ScopedComPtr::CreateInstance() to CoCreateInstance().

BUG=638327
==========

to

==========
Remove ScopedComPtr::CreateInstance()

This is better expressed as directly calling CoCreateInstance().

This change is a mechanical refactor from
ScopedComPtr::CreateInstance() to CoCreateInstance().

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[robliao, 2017-05-17 22:02:55]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 22:06:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robliao, 2017-05-17 23:00:14]

robliao@chromium.org changed reviewers:
+ scottmg@chromium.org

[robliao, 2017-05-17 23:00:14]

scottmg: Please review this change. Thanks!

[scottmg, 2017-05-17 23:04:11]

lgtm

[robliao, 2017-05-17 23:57:54]

Description was changed from

==========
Remove ScopedComPtr::CreateInstance()

This is better expressed as directly calling CoCreateInstance().

This change is a mechanical refactor from
ScopedComPtr::CreateInstance() to CoCreateInstance().

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove ScopedComPtr::CreateInstance()

This is better expressed as directly calling CoCreateInstance().

This change is a mechanical refactor from
ScopedComPtr::CreateInstance() to CoCreateInstance().

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[robliao, 2017-05-17 23:57:54]

robliao@chromium.org changed reviewers:
+ dalecurtis@chromium.org, jam@chromium.org, reillyg@chromium.org,
rsleevi@chromium.org, sdefresne@chromium.org, thakis@chromium.org,
wez@chromium.org

[robliao, 2017-05-17 23:58:11]

Description was changed from

==========
Remove ScopedComPtr::CreateInstance()

This is better expressed as directly calling CoCreateInstance().

This change is a mechanical refactor from
ScopedComPtr::CreateInstance() to CoCreateInstance().

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove ScopedComPtr::CreateInstance()

This is better expressed as directly calling CoCreateInstance().

This change is a mechanical refactor from
ScopedComPtr::CreateInstance() to CoCreateInstance().

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, jam@chromium.org, reillyg@chromium.org,
rsleevi@chromium.org, sdefresne@chromium.org, thakis@chromium.org,
wez@chromium.org, 
Mechanical refactor.
==========

[robliao, 2017-05-17 23:58:27]

TBR'ing top-level directory owners for this mechanical refactor.

Owners:

dalecurtis:
  media/*

jam:
  content/*

reillyg:
  device/*  

rsleevi:
  net/*

sdefresne:
  components/*

thakis:
  base/*
  ui/*

wez:
  remoting/*

[robliao, 2017-05-17 23:59:54]

Description was changed from

==========
Remove ScopedComPtr::CreateInstance()

This is better expressed as directly calling CoCreateInstance().

This change is a mechanical refactor from
ScopedComPtr::CreateInstance() to CoCreateInstance().

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, jam@chromium.org, reillyg@chromium.org,
rsleevi@chromium.org, sdefresne@chromium.org, thakis@chromium.org,
wez@chromium.org, 
Mechanical refactor.
==========

to

==========
Remove ScopedComPtr::CreateInstance()

This is better expressed as directly calling CoCreateInstance().

This change is a mechanical refactor from
ScopedComPtr::CreateInstance() to CoCreateInstance().

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, jam@chromium.org, reillyg@chromium.org,
rsleevi@chromium.org, sdefresne@chromium.org, thakis@chromium.org,
nicholss@chromium.org, 
Mechanical refactor.
==========

[robliao, 2017-05-17 23:59:54]

robliao@chromium.org changed reviewers:
+ nicholss@chromium.org
- wez@chromium.org

[robliao, 2017-05-18 00:00:35]

Owners update
s/wez/nicholss/

nicholss:
  remoting/*

[Reilly Grant (use Gerrit), 2017-05-18 00:03:40]

device lgtm

[Ryan Sleevi, 2017-05-18 00:14:50]

lgtm

[Hzj_jie, 2017-05-18 00:18:56]

On 2017/05/18 00:14:50, Ryan Sleevi wrote:
> lgtm

The expression becomes more complex. Is there any reason to prefer
::CoCreateInstance() than ScopedComPtr::CreateInstance()?

[robliao, 2017-05-18 00:24:10]

On 2017/05/18 00:18:56, Hzj_jie wrote:
> On 2017/05/18 00:14:50, Ryan Sleevi wrote:
> > lgtm
> 
> The expression becomes more complex. Is there any reason to prefer
> ::CoCreateInstance() than ScopedComPtr::CreateInstance()?

This CL brings Chromium closer to alignment for ComPtr, which doesn't provide
CreateInstance().
See
https://docs.google.com/document/d/17cNzJGKO8a8r1mMDNL7Gycafa-8AMXz54VeAXtow9...
for more details.

Taking a step back, the expression is of similar complexity as you need to (or
should) specify the receiver, CLSID, pUnkOuter (generally nullptr), and class
context in the construction statement.

[Hzj_jie, 2017-05-18 00:25:29]

On 2017/05/18 00:24:10, robliao wrote:
> On 2017/05/18 00:18:56, Hzj_jie wrote:
> > On 2017/05/18 00:14:50, Ryan Sleevi wrote:
> > > lgtm
> > 
> > The expression becomes more complex. Is there any reason to prefer
> > ::CoCreateInstance() than ScopedComPtr::CreateInstance()?
> 
> This CL brings Chromium closer to alignment for ComPtr, which doesn't provide
> CreateInstance().
> See
>
https://docs.google.com/document/d/17cNzJGKO8a8r1mMDNL7Gycafa-8AMXz54VeAXtow9...
> for more details.
> 
> Taking a step back, the expression is of similar complexity as you need to (or
> should) specify the receiver, CLSID, pUnkOuter (generally nullptr), and class
> context in the construction statement.

Got you, thank you.

[commit-bot: I haz the power, 2017-05-18 00:55:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 00:55:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[robliao, 2017-05-18 01:09:08]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 01:10:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 04:53:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 04:53:10]

Dry run: This issue passed the CQ dry run.

[jam, 2017-05-18 14:17:04]

lgtm

[robliao, 2017-05-18 17:22:33]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2017-05-18 17:23:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 17:35:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495128153785310, "parent_rev":
"e4cc35c01c052ed93ac46727085ef52d98a0217f", "commit_rev":
"eb9bfd648536ce835bb62026506bd29395de3f88"}

[commit-bot: I haz the power, 2017-05-18 17:35:34]

Description was changed from

==========
Remove ScopedComPtr::CreateInstance()

This is better expressed as directly calling CoCreateInstance().

This change is a mechanical refactor from
ScopedComPtr::CreateInstance() to CoCreateInstance().

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, jam@chromium.org, reillyg@chromium.org,
rsleevi@chromium.org, sdefresne@chromium.org, thakis@chromium.org,
nicholss@chromium.org, 
Mechanical refactor.
==========

to

==========
Remove ScopedComPtr::CreateInstance()

This is better expressed as directly calling CoCreateInstance().

This change is a mechanical refactor from
ScopedComPtr::CreateInstance() to CoCreateInstance().

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, jam@chromium.org, reillyg@chromium.org,
rsleevi@chromium.org, sdefresne@chromium.org, thakis@chromium.org,
nicholss@chromium.org, 
Mechanical refactor.

Review-Url: https://codereview.chromium.org/2887243002
Cr-Commit-Position: refs/heads/master@{#472858}
Committed:
https://chromium.googlesource.com/chromium/src/+/eb9bfd648536ce835bb62026506b...
==========

[commit-bot: I haz the power, 2017-05-18 17:35:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eb9bfd648536ce835bb62026506b...

[sdefresne, 2017-05-22 14:33:38]

lgtm