Convert quick fix support to use AnalysisDriver

Convert quick fix support to use AnalysisDriver

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/7e47a24c8a06a48d78e5aa9b103b234509dc61fb

[Brian Wilkerson, 2017-05-22 14:30:16]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-05-22 15:48:55]

lgtm

https://codereview.chromium.org/2894403003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/2894403003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:166: if
(_typeProvider == null) {
We are already given dartContext.unit, with its element.
So, we can get AnalysisContext (even if temporary) and get TypeProvider and
TypeSystem from it.
In the future we could replace AnalysisContext with AnalysisSession, associated
with the resolved unit, and still be able to get TypeProvider from it.

https://codereview.chromium.org/2894403003/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/correction/fix_test.dart (right):

https://codereview.chromium.org/2894403003/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/correction/fix_test.dart:6889: class
_DartFixContextImpl implements DartFixContext {
It seems to me that separation between FixContext, DartFixContext and
DartFixContextImpl is not necessary now. We work only with Dart, and only we
(DAS) work with it. Plugins has their own infrastructure.

Not for this CL of course.
Just something I think could be fixed in the future.

[Brian Wilkerson, 2017-05-22 16:03:01]

https://codereview.chromium.org/2894403003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/2894403003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:166: if
(_typeProvider == null) {
Is it better to introduce a temporary dependency on AnalysisContext, or should
we just eliminate the dependency now?

In the not-too-distant future I actually want to replace the `driver` field with
an AnalysisSession.

https://codereview.chromium.org/2894403003/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/correction/fix_test.dart (right):

https://codereview.chromium.org/2894403003/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/correction/fix_test.dart:6889: class
_DartFixContextImpl implements DartFixContext {
> Plugins has their own infrastructure.

I would like to share as much code as possible between server and plugins, but I
agree we should take a look at this after we've figured out how to provide as
much implementation for fixes and assists as possible for plugins.

[scheglov, 2017-05-22 16:07:34]

https://codereview.chromium.org/2894403003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/2894403003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:166: if
(_typeProvider == null) {
On 2017/05/22 16:03:01, Brian Wilkerson wrote:
> Is it better to introduce a temporary dependency on AnalysisContext, or should
> we just eliminate the dependency now?
> 
> In the not-too-distant future I actually want to replace the `driver` field
with
> an AnalysisSession.

I think it is better to keep AnalysisContext dependency (which you don't even
have to put explicitly into a variable) and then replace it with
AnalysisSession. Less async/await through the code anyway.

[Brian Wilkerson, 2017-05-22 17:41:12]

https://codereview.chromium.org/2894403003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/2894403003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:166: if
(_typeProvider == null) {
> Less async/await through the code anyway.

I've put it back for now, but the next step for this class is to convert it to
use ChangeBuilder, so all of the async will come back anyway.

[Brian Wilkerson, 2017-05-22 17:42:02]

Description was changed from

==========
Convert quick fix support to use AnalysisDriver
==========

to

==========
Convert quick fix support to use AnalysisDriver

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7e47a24c8a06a48d78e5aa9b103b234509dc61fb
==========

[Brian Wilkerson, 2017-05-22 17:42:04]

Committed patchset #1 (id:1) manually as
7e47a24c8a06a48d78e5aa9b103b234509dc61fb (presubmit successful).