Convert quick fix support to use AnalysisDriver

pkg/analysis_server/test/services/correction/fix_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analysis_server/plugin/edit/fix/fix_core.dart';
 import 'package:analysis_server/plugin/edit/fix/fix_dart.dart';
 import 'package:analysis_server/src/services/correction/fix.dart';
 import 'package:analysis_server/src/services/correction/fix_internal.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/standard_resolution_map.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/source/package_map_resolver.dart';
 import 'package:analyzer/src/dart/analysis/ast_provider_driver.dart';
+import 'package:analyzer/src/dart/analysis/driver.dart';
 import 'package:analyzer/src/dart/element/ast_provider.dart';
 import 'package:analyzer/src/error/codes.dart';
-import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/parser.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer_plugin/protocol/protocol_common.dart'
     hide AnalysisError;
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import '../../abstract_single_unit.dart';
 import 'flutter_util.dart';
 
@@ skipping 127 matching lines @@
       return (await driver.getResult(testFile)).errors;
     } else {
       return context.computeErrors(testSource);
     }
   }
 
   /**
    * Computes fixes for the given [error] in [testUnit].
    */
   Future<List<Fix>> _computeFixes(AnalysisError error) async {
-    if (enableNewAnalysisDriver) {
-      DartFixContext fixContext = new _DartFixContextImpl(
-          provider,
-          driver.getTopLevelNameDeclarations,
-          resolutionMap.elementDeclaredByCompilationUnit(testUnit).context,
-          new AstProviderForDriver(driver),
-          testUnit,
-          error);
-      return await new DefaultFixContributor().internalComputeFixes(fixContext);
-    } else {
-      FixContextImpl fixContext = new FixContextImpl(provider, context, error);
-      DefaultFixContributor contributor = new DefaultFixContributor();
-      return contributor.computeFixes(fixContext);
-    }
+    DartFixContext fixContext = new _DartFixContextImpl(
+        provider, driver, new AstProviderForDriver(driver), testUnit, error);
+    return await new DefaultFixContributor().internalComputeFixes(fixContext);
   }
 
   /**
    * Configures the [SourceFactory] to have the `my_pkg` package in
    * `/packages/my_pkg/lib` folder.
    */
   void _configureMyPkg(Map<String, String> pathToCode) {
     pathToCode.forEach((path, code) {
       provider.newFile('$myPkgLibPath/$path', code);
     });
@@ skipping 6699 matching lines @@
   return a.toString;
 }
 ''');
   }
 
   void verifyResult(String expectedResult) {
     expect(resultCode, expectedResult);
   }
 }
 
 class _DartFixContextImpl implements DartFixContext {

[scheglov, 2017/05/22 15:48:55]

It seems to me that separation between FixContext, DartFixContext and
DartFixContextImpl is not necessary now. We work only with Dart, and only we
(DAS) work with it. Plugins has their own infrastructure.

Not for this CL of course.
Just something I think could be fixed in the future.

[Brian Wilkerson, 2017/05/22 16:03:01]

I would like to share as much code as possible between server and plugins, but I
agree we should take a look at this after we've figured out how to provide as
much implementation for fixes and assists as possible for plugins.

   @override
   final ResourceProvider resourceProvider;
 
   @override
-  final GetTopLevelDeclarations getTopLevelDeclarations;
-
-  @override
-  final AnalysisContext analysisContext;
+  final AnalysisDriver analysisDriver;
 
   @override
   final AstProvider astProvider;
 
   @override
   final CompilationUnit unit;
 
   @override
   final AnalysisError error;
 
-  _DartFixContextImpl(this.resourceProvider, this.getTopLevelDeclarations,
-      this.analysisContext, this.astProvider, this.unit, this.error);
+  _DartFixContextImpl(this.resourceProvider, this.analysisDriver,
+      this.astProvider, this.unit, this.error);
+
+  @override
+  GetTopLevelDeclarations get getTopLevelDeclarations =>
+      analysisDriver.getTopLevelNameDeclarations;
 }