Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: pkg/analysis_server/lib/src/services/correction/fix.dart

Issue 2894403003: Convert quick fix support to use AnalysisDriver (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/correction/fix.dart
diff --git a/pkg/analysis_server/lib/src/services/correction/fix.dart b/pkg/analysis_server/lib/src/services/correction/fix.dart
index d76efe75ac5bfdc32a7be3e4e833db2a78218023..153bda58e2fbc33d8e664421cc4ac5c33a279828 100644
--- a/pkg/analysis_server/lib/src/services/correction/fix.dart
+++ b/pkg/analysis_server/lib/src/services/correction/fix.dart
@@ -2,48 +2,15 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import 'dart:async';
-
import 'package:analysis_server/plugin/edit/fix/fix_core.dart';
-import 'package:analysis_server/src/plugin/server_plugin.dart';
import 'package:analysis_server/src/services/correction/fix_internal.dart';
import 'package:analyzer/error/error.dart';
-import 'package:analyzer/exception/exception.dart';
import 'package:analyzer/file_system/file_system.dart';
+import 'package:analyzer/src/dart/analysis/driver.dart';
import 'package:analyzer/src/error/codes.dart';
-import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/parser.dart';
/**
- * Compute and return the fixes available for the given [error]. The error was
- * reported after it's source was analyzed in the given [context]. The [plugin]
- * is used to get the list of fix contributors.
- */
-Future<List<Fix>> computeFixes(
- ServerPlugin plugin,
- ResourceProvider resourceProvider,
- AnalysisContext context,
- AnalysisError error) async {
- List<Fix> fixes = <Fix>[];
- List<FixContributor> contributors = plugin.fixContributors;
- FixContext fixContext = new FixContextImpl(resourceProvider, context, error);
- for (FixContributor contributor in contributors) {
- try {
- List<Fix> contributedFixes = await contributor.computeFixes(fixContext);
- if (contributedFixes != null) {
- fixes.addAll(contributedFixes);
- }
- } catch (exception, stackTrace) {
- AnalysisEngine.instance.logger.logError(
- 'Exception from fix contributor: ${contributor.runtimeType}',
- new CaughtException(exception, stackTrace));
- }
- }
- fixes.sort(Fix.SORT_BY_RELEVANCE);
- return fixes;
-}
-
-/**
* Return true if this [errorCode] is likely to have a fix associated with it.
*/
bool hasFix(ErrorCode errorCode) =>
@@ -266,15 +233,15 @@ class FixContextImpl implements FixContext {
final ResourceProvider resourceProvider;
@override
- final AnalysisContext analysisContext;
+ final AnalysisDriver analysisDriver;
@override
final AnalysisError error;
- FixContextImpl(this.resourceProvider, this.analysisContext, this.error);
+ FixContextImpl(this.resourceProvider, this.analysisDriver, this.error);
FixContextImpl.from(FixContext other)
: resourceProvider = other.resourceProvider,
- analysisContext = other.analysisContext,
+ analysisDriver = other.analysisDriver,
error = other.error;
}

Powered by Google App Engine
This is Rietveld 408576698