[ObjC ARC] Converts ios/chrome/app/safe_mode:safe_mode to ARC.

ios/chrome/app/safe_mode/safe_mode_coordinator.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/app/safe_mode/safe_mode_coordinator.h"

[stkhapugin, 2017/05/30 13:36:37]

In this header, update:

@property(nonatomic, nullable, assign) id<SafeModeCoordinatorDelegate> delegate;

to:

@property(nonatomic, nullable, weak) id<SafeModeCoordinatorDelegate> delegate;

[rohitrao (ping after 24h), 2017/05/30 15:05:07]

Should the migration tools be updating header files?  Why didn't they update
this one?

[lindsayw, 2017/06/01 15:35:44]

Done.

 
-#include "base/mac/scoped_nsobject.h"
 #import "ios/chrome/app/safe_mode/safe_mode_view_controller.h"
 #include "ios/chrome/browser/crash_loop_detection_util.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace {
 const int kStartupCrashLoopThreshold = 2;
 }
 
 @interface SafeModeCoordinator ()<SafeModeViewControllerDelegate> {
   // Weak pointer to window passed on init.

[lindsayw, 2017/05/19 12:03:07]

stk@ Please let me know how you would like these comments updated.

[stkhapugin, 2017/05/30 13:36:37]

I'm okay with keeping them as is. 

[rohitrao (ping after 24h), 2017/05/30 15:05:07]

I would just get rid of the comments on lines 19 and 21.  I don't think they add
much now that the variables themselves are annotated.

[lindsayw, 2017/06/01 15:35:44]

Done.

-  base::WeakNSObject<UIWindow> _window;
+  __weak UIWindow* _window;
   // Weak pointer backing property of the same name.
-  base::WeakNSProtocol<id<SafeModeCoordinatorDelegate>> _delegate;
+  __weak id<SafeModeCoordinatorDelegate> _delegate;

[stkhapugin, 2017/05/30 13:36:37]

Remove this ivar and put:

@implementation SafeModeCoordinator
@synthesize delegate = _delegate; 

[lindsayw, 2017/06/01 15:35:44]

Done.

 }
 
 @end
 
 @implementation SafeModeCoordinator
 
 #pragma mark - property implementation.
 
 - (id<SafeModeCoordinatorDelegate>)delegate {

[stkhapugin, 2017/05/30 13:36:37]

Remove this getter

[lindsayw, 2017/06/01 15:35:44]

Done.

   return _delegate;
 }
 
 - (void)setDelegate:(id<SafeModeCoordinatorDelegate>)delegate {
-  _delegate.reset(delegate);
+  _delegate = delegate;

[stkhapugin, 2017/05/30 13:36:37]

Remove this setter.

[lindsayw, 2017/06/01 15:35:44]

Done.

 }
 
 #pragma mark - Public class methods
 
 + (BOOL)shouldStart {
   // Check whether there appears to be a startup crash loop. If not, don't look
   // at anything else.
   if (crash_util::GetFailedStartupAttemptCount() < kStartupCrashLoopThreshold)
     return NO;
 
   return [SafeModeViewController hasSuggestions];
 }
 
 #pragma mark - ChromeCoordinator implementation
 
 - (void)start {
   // Create the SafeModeViewController and make it the root view controller for
   // the window. The window has ownership of it and will dispose of it when
   // another view controller is made root.
   //
   // General note: Safe mode should be safe; it should not depend on other
   // objects being created. Be extremely conservative when adding code to this
   // method.
-  base::scoped_nsobject<SafeModeViewController> viewController(
-      [[SafeModeViewController alloc] initWithDelegate:self]);
+  SafeModeViewController* viewController =
+      [[SafeModeViewController alloc] initWithDelegate:self];
   [self.window setRootViewController:viewController];
 
   // Reset the crash count; the user may change something based on the recovery
   // UI that will fix the crash, and having the next launch start in recovery
   // mode would be strange.
   crash_util::ResetFailedStartupAttemptCount();
 }
 
 // Override of ChildCoordinators method, which is not supported in this class.
 - (MutableCoordinatorArray*)childCoordinators {
   NOTREACHED() << "Do not add child coordinators to SafeModeCoordinator.";
   return nil;
 }
 
 #pragma mark - SafeModeViewControllerDelegate implementation
 
 - (void)startBrowserFromSafeMode {
   [self.delegate coordinatorDidExitSafeMode:self];
 }
 
 @end