Views a11y: Add AXNodeData.actions bitfield to indicate supported actions by UI.

Views a11y: Add AXNodeData.actions bitfield to indicate supported actions by UI.

AXActions are used to perform actions on an a11y element, such as changing the
value of a textfield, focus/blur an element, etc. However, currently there is no
way to indicate that an element actually supports that particular action, e.g.
a numerical combobox that allows text input may support three actions -
'left click' (to focus the text field), 'increment', and 'decrement', but might
not do anything on 'right click' (which would typically show a context menu).

Add a new |actions| bitfield on AXNodeData to allow a11y elements to indicate
which actions they actually support, and remove the |can_set_value| attribute
since we now have a general solution for all AXActions.

BUG=717846
Review-Url: https://codereview.chromium.org/2799413002
Cr-Commit-Position: refs/heads/master@{#473515}
Committed: https://chromium.googlesource.com/chromium/src/+/979beede7c397098ba05931fd1f29792a95472eb

[Patti Lor, 2017-04-07 06:35:19]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 06:35:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 06:45:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 06:45:25]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Patti Lor, 2017-04-07 08:36:01]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 08:36:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 08:44:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 08:44:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Patti Lor, 2017-04-12 07:56:16]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 07:56:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 08:00:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 08:00:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Patti Lor, 2017-04-12 08:14:01]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 08:14:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 08:26:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 08:26:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-04-13 01:44:54]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 01:45:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 02:01:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 02:01:52]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-04-13 04:49:57]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 04:50:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 05:09:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 05:09:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-04-13 05:12:24]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 05:12:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 05:41:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 05:41:34]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Patti Lor, 2017-04-19 05:27:44]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 05:28:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 05:32:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 05:32:19]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Patti Lor, 2017-04-19 06:04:05]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 06:04:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 06:23:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 06:23:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-04-19 06:29:44]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 06:30:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 07:00:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 07:00:24]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Patti Lor, 2017-04-19 07:30:30]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 07:30:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 08:06:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 08:06:23]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Patti Lor, 2017-04-19 08:24:28]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 08:24:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 09:00:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 09:00:49]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Patti Lor, 2017-04-20 01:56:23]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 01:56:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 02:48:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 02:49:00]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Patti Lor, 2017-04-20 04:04:13]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 04:04:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 04:44:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 04:44:13]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Patti Lor, 2017-04-20 05:07:01]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 05:07:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 05:39:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 05:39:28]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Patti Lor, 2017-04-20 06:51:34]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 06:51:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 08:34:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 08:34:04]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Patti Lor, 2017-04-24 03:33:08]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 03:33:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patti Lor, 2017-04-24 03:54:39]

Patchset #17 (id:320001) has been deleted

[Patti Lor, 2017-04-24 04:47:03]

Patchset #16 (id:300001) has been deleted

[Patti Lor, 2017-04-24 04:54:41]

Description was changed from

==========
Views a11y: Refactor AXSupportedActions to support more than one action.

AXSupportedActions are used to indicate what 'actions' are supported by UI
elements (e.g., 'click', 'check', etc). Currently, only one action can be
supported at a time, which doesn't allow for use cases like 'click' and 'right
click'. Do some refactoring to:

1. Allow more than one action to be supported at a time.
2. Allow future bitfield-type a11y information to be easily stored in
   AXNodeData::bitfield_attributes.

BUG=679247
==========

to

==========
Views a11y: Refactor AXSupportedActions to support more than one action.

AXSupportedActions are used to indicate what 'actions' are supported by UI
elements (e.g., 'click', 'check', etc). Currently, a11y elements can only
indicate that they support one action at a time, which doesn't work for controls
that (for example) have left and right 'click' actions. Do some refactoring to:

- Allow more than one action to be supported at a time.
- Easily clear all bitfields before use on AXNodeData with a new method
  'ClearBitfields()'.

BUG=679247
==========

[commit-bot: I haz the power, 2017-04-24 05:13:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 05:13:38]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Patti Lor, 2017-04-27 07:23:27]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 07:23:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 07:41:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 07:41:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-04-27 07:51:37]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 07:51:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 09:13:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 09:14:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-04-28 01:40:16]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 01:41:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 03:07:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 03:07:26]

Dry run: This issue passed the CQ dry run.

[Patti Lor, 2017-04-28 06:20:31]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 06:20:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 06:42:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 06:42:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-04-28 07:39:58]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 07:40:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patti Lor, 2017-04-28 08:19:01]

patricialor@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[Patti Lor, 2017-04-28 08:19:03]

Hi Dominic, PTAL? I added a new bitfield |AXNodeData::supported_actions| and
removed ui::AX_ATTR_ACTION, so that we have a similar thing to
|AXNodeData::state|. Apart from that, most of the functionality should be
preserved. I did make a couple changes to AXPlatformNodeWin /
BrowserAccessibilityWin / BrowserAccessibilityAuraLinux in the hopes of making
stuff more consistent - I left comments to explain why, but happy to revert if
you disagree.

A lot of the changes here are just renames, so I made a list of files which have
relevant changes which will hopefully help:

chrome/common/extensions/chrome_extension_messages.h
content/browser/accessibility/accessibility_tree_formatter_blink.cc
content/browser/accessibility/browser_accessibility.h
content/browser/accessibility/browser_accessibility.cc
content/browser/accessibility/browser_accessibility_android.cc
content/browser/accessibility/browser_accessibility_auralinux.cc
content/browser/accessibility/browser_accessibility_win.cc
content/common/accessibility_messages.h
content/renderer/accessibility/blink_ax_tree_source.cc
content/test/data/accessibility/html/action-verbs.html
content/test/data/accessibility/html/action-verbs-expected-blink.txt
ui/accessibility/ax_enums.idl
ui/accessibility/ax_node_data.h
ui/accessibility/ax_node_data.cc
ui/accessibility/ax_tree_unittest.cc
ui/accessibility/platform/ax_platform_node_auralinux.cc
ui/accessibility/platform/ax_platform_node_mac.mm
ui/accessibility/platform/ax_platform_node_win.cc
ui/views/controls/button/checkbox.cc

Thanks in advance!

[commit-bot: I haz the power, 2017-04-28 08:52:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 08:52:04]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-04-28 22:36:08]

No big concerns about the code changes, just some
high-level questions first:

* Your canonical example of why you need two actions
  is right-click, but can't you right-click on anything?
  I can't find a single example of something in Chrome
  that I can't right-click on, since there's always an
  ancestor or fallback context menu. Not saying we might
  not want to expose it as an action, but is there a
  better canonical example of a control that supports more
  than one action?

* How is BrowserAccessibilityWin::get_accDefaultAction
  supposed to work if there are multiple actions?
  Does "click" always need to be the first action?
  I just think it needs to be better documented or
  enforced. I know we only support one action now,
  but I just want to better understand how it ought to
  work in the future.

[Patti Lor, 2017-05-01 06:04:44]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 06:04:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 06:08:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 06:08:36]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Patti Lor, 2017-05-01 06:39:52]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 06:40:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 07:11:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 07:11:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-05-01 08:33:47]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 08:34:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 09:00:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 09:00:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dmazzoni, 2017-05-01 16:11:17]

Follow-up question. It's totally fine if you don't
*solve* this issue in this changelist, I just want us
to all be on the same page with regards to actions
and have a good long-term plan.

Right now we have both AXAction and AXSupportedAction.
While the names are not very clear, the comments in
ax_enums.idl are not bad.

In practice, AXSupportedAction is there to reflect
the different possible semantics for the "default"
action - while there are lots of things that have a
default / click action, the verb associated with them
is quite different, like "click", "check", "select",
etc.

I wonder if we should just merge them, or map them?

* Merge: What if we just had AXAction, but made that
  a bitmask, and let each object report which actions
  it supports? Then we'd have separate actions for
  click, check, uncheck, select, etc. - but the actual
  implementation of many of these would be to do the
  same thing, i.e. in Blink maybe we'd still just map
  a lot of those to DoDefaultAction.

* Map: Keep AXAction and AXSupportedAction separate,
  where AXAction is the underlying methods, and
  AXSupportedAction is the user-visible verb for each
  one. Maybe AXSupportedAction should be renamed
  AXActionVerb or something like that. But then we'd
  add extra action verbs to correspond with every
  possible AXAction, too.

[Patti Lor, 2017-05-02 05:06:01]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 05:06:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patti Lor, 2017-05-02 05:36:47]

Description was changed from

==========
Views a11y: Refactor AXSupportedActions to support more than one action.

AXSupportedActions are used to indicate what 'actions' are supported by UI
elements (e.g., 'click', 'check', etc). Currently, a11y elements can only
indicate that they support one action at a time, which doesn't work for controls
that (for example) have left and right 'click' actions. Do some refactoring to:

- Allow more than one action to be supported at a time.
- Easily clear all bitfields before use on AXNodeData with a new method
  'ClearBitfields()'.

BUG=679247
==========

to

==========
Views a11y: Refactor AXSupportedActions to support more than one action.

AXSupportedActions are used to indicate what 'actions' are supported by UI
elements (e.g., 'click', 'check', etc). Currently, a11y elements can only
indicate that they support one action at a time, which doesn't support all use
cases. For example, a numerical combobox that allows text input may support
three actions - 'left click' (to focus the text field), 'increment', and
'decrement'.
Do some refactoring to:

- Allow more than one action to be supported at a time.
- Easily clear all bitfields before use on AXNodeData with a new method
  'ClearBitfields()'.

BUG=679247
==========

[commit-bot: I haz the power, 2017-05-02 06:19:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 06:19:05]

Dry run: This issue passed the CQ dry run.

[Patti Lor, 2017-05-02 08:14:32]

On 2017/05/01 16:11:17, dmazzoni wrote:
> Follow-up question. It's totally fine if you don't
> *solve* this issue in this changelist, I just want us
> to all be on the same page with regards to actions
> and have a good long-term plan.
> 
> Right now we have both AXAction and AXSupportedAction.
> While the names are not very clear, the comments in
> ax_enums.idl are not bad.
> 
> In practice, AXSupportedAction is there to reflect
> the different possible semantics for the "default"
> action - while there are lots of things that have a
> default / click action, the verb associated with them
> is quite different, like "click", "check", "select",
> etc.
> 
> I wonder if we should just merge them, or map them?
> 
> * Merge: What if we just had AXAction, but made that
>   a bitmask, and let each object report which actions
>   it supports? Then we'd have separate actions for
>   click, check, uncheck, select, etc. - but the actual
>   implementation of many of these would be to do the
>   same thing, i.e. in Blink maybe we'd still just map
>   a lot of those to DoDefaultAction.
> 
> * Map: Keep AXAction and AXSupportedAction separate,
>   where AXAction is the underlying methods, and
>   AXSupportedAction is the user-visible verb for each
>   one. Maybe AXSupportedAction should be renamed
>   AXActionVerb or something like that. But then we'd
>   add extra action verbs to correspond with every
>   possible AXAction, too.

(Answering your questions out of order because your second email explained a few
things I didn't know about)

1. Yeah, I think my example applies more to Views controls than Blink... e.g.
you have the back/forward button that has a left click *and* right click/long
press action, but the home button only has left click. Maybe for Blink stuff a
better example would be that mixed state checkboxes should support being checked
and unchecked at the same time? Or potentially a text-editable combobox where
you can increment and decrement it and also type? I updated the CL description
with the last example because that seems easiest to understand without the
right-click-being-available-everywhere in the web contents problem.

3. Oh, that makes so much sense now - I didn't realise that AXSupportedAction
were just different verbs to describe click actions. I like the merge option -
it seems cleaner than having two separate enums, with some of them having more
than one action verb. Maybe in this case though it would be good to add an
AXIntAttribute "AX_DEFAULT_ACTION_VERB" or something, where we can store an
AXAction for get_accDefaultAction and similar methods to return strings for.
(This would only work if the default action was permanently just a click,
assuming that's what we want.)

2. Assuming we want the default action to always be a click, but we want to vary
the action verb for it, then the second part of my answer to 2) would solve that
I think (with an AXIntAttribute to store the enum for the appropriate string to
return). From your second email, I think the changes I made to all the
get_accDefaultAction methods are incorrect - it might be best to just DCHECK
there's only 1 action available and return the string for that, until we can
agree on a plan for how to work out what the default action verb string should
be. I'll work on doing that, and I'll ping this CL again when it's ready for
another review :)

Also, a heads up that I will probably extract our discussion here and try to put
it into context in new bug as well (will do this tomorrow). (Though feel free to
do this yourself if you have time.)

Thanks Dominic!

[dmazzoni, 2017-05-02 15:37:38]

I agree, there should be a way to indicate whether you can right-click on
something, since in Views it's not always the case.

Oh, one last piece of the puzzle, we currently have a bool attribute
can_set_value. That's kind of the equivalent of saying that the "set value"
action is available. Up until now we were able to handle what things are
clickable, and what things could have their value changed, but we didn't
have any other way of exposing what other actions are supported.

So one way or another all of these should be unified more.

It sounds like what's really needed is to have a bitmask of all of the
supported actions, then rename what we call "supported action" to be the
action verb for the default action.


On Tue, May 2, 2017 at 1:14 AM <patricialor@chromium.org> wrote:

> On 2017/05/01 16:11:17, dmazzoni wrote:
> > Follow-up question. It's totally fine if you don't
> > *solve* this issue in this changelist, I just want us
> > to all be on the same page with regards to actions
> > and have a good long-term plan.
> >
> > Right now we have both AXAction and AXSupportedAction.
> > While the names are not very clear, the comments in
> > ax_enums.idl are not bad.
> >
> > In practice, AXSupportedAction is there to reflect
> > the different possible semantics for the "default"
> > action - while there are lots of things that have a
> > default / click action, the verb associated with them
> > is quite different, like "click", "check", "select",
> > etc.
> >
> > I wonder if we should just merge them, or map them?
> >
> > * Merge: What if we just had AXAction, but made that
> > a bitmask, and let each object report which actions
> > it supports? Then we'd have separate actions for
> > click, check, uncheck, select, etc. - but the actual
> > implementation of many of these would be to do the
> > same thing, i.e. in Blink maybe we'd still just map
> > a lot of those to DoDefaultAction.
> >
> > * Map: Keep AXAction and AXSupportedAction separate,
> > where AXAction is the underlying methods, and
> > AXSupportedAction is the user-visible verb for each
> > one. Maybe AXSupportedAction should be renamed
> > AXActionVerb or something like that. But then we'd
> > add extra action verbs to correspond with every
> > possible AXAction, too.
>
> (Answering your questions out of order because your second email explained
> a few
> things I didn't know about)
>
> 1. Yeah, I think my example applies more to Views controls than Blink...
> e.g.
> you have the back/forward button that has a left click *and* right
> click/long
> press action, but the home button only has left click. Maybe for Blink
> stuff a
> better example would be that mixed state checkboxes should support being
> checked
> and unchecked at the same time? Or potentially a text-editable combobox
> where
> you can increment and decrement it and also type? I updated the CL
> description
> with the last example because that seems easiest to understand without the
> right-click-being-available-everywhere in the web contents problem.
>
> 3. Oh, that makes so much sense now - I didn't realise that
> AXSupportedAction
> were just different verbs to describe click actions. I like the merge
> option -
> it seems cleaner than having two separate enums, with some of them having
> more
> than one action verb. Maybe in this case though it would be good to add an
> AXIntAttribute "AX_DEFAULT_ACTION_VERB" or something, where we can store an
> AXAction for get_accDefaultAction and similar methods to return strings
> for.
> (This would only work if the default action was permanently just a click,
> assuming that's what we want.)
>
> 2. Assuming we want the default action to always be a click, but we want
> to vary
> the action verb for it, then the second part of my answer to 2) would
> solve that
> I think (with an AXIntAttribute to store the enum for the appropriate
> string to
> return). From your second email, I think the changes I made to all the
> get_accDefaultAction methods are incorrect - it might be best to just
> DCHECK
> there's only 1 action available and return the string for that, until we
> can
> agree on a plan for how to work out what the default action verb string
> should
> be. I'll work on doing that, and I'll ping this CL again when it's ready
> for
> another review :)
>
> Also, a heads up that I will probably extract our discussion here and try
> to put
> it into context in new bug as well (will do this tomorrow). (Though feel
> free to
> do this yourself if you have time.)
>
> Thanks Dominic!
>
> https://codereview.chromium.org/2799413002/
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Patti Lor, 2017-05-19 03:14:35]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 03:15:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patti Lor, 2017-05-19 03:28:46]

Description was changed from

==========
Views a11y: Refactor AXSupportedActions to support more than one action.

AXSupportedActions are used to indicate what 'actions' are supported by UI
elements (e.g., 'click', 'check', etc). Currently, a11y elements can only
indicate that they support one action at a time, which doesn't support all use
cases. For example, a numerical combobox that allows text input may support
three actions - 'left click' (to focus the text field), 'increment', and
'decrement'.
Do some refactoring to:

- Allow more than one action to be supported at a time.
- Easily clear all bitfields before use on AXNodeData with a new method
  'ClearBitfields()'.

BUG=679247
==========

to

==========
Views a11y: Add AXNodeData.actions bitfield to indicate supported actions by UI.

AXActions are used to perform actions on an a11y element, such as changing the
value of a textfield, focus/blur an element, etc. However, currently there is no
way to indicate that an element actually supports that particular action, e.g.
a numerical combobox that allows text input may support three actions -
'left click' (to focus the text field), 'increment', and 'decrement', but might
not do anything on 'right click' (which would typically show a context menu).

Add a new |actions| bitfield on AXNodeData to allow a11y elements to indicate
which actions they actually support, and remove the |can_set_value| attribute
since we now have a general solution for all AXActions.

BUG=679247
==========

[commit-bot: I haz the power, 2017-05-19 04:04:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 04:04:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-05-19 04:43:09]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 04:43:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 06:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 06:55:22]

Dry run: This issue passed the CQ dry run.

[Patti Lor, 2017-05-19 07:33:48]

Description was changed from

==========
Views a11y: Add AXNodeData.actions bitfield to indicate supported actions by UI.

AXActions are used to perform actions on an a11y element, such as changing the
value of a textfield, focus/blur an element, etc. However, currently there is no
way to indicate that an element actually supports that particular action, e.g.
a numerical combobox that allows text input may support three actions -
'left click' (to focus the text field), 'increment', and 'decrement', but might
not do anything on 'right click' (which would typically show a context menu).

Add a new |actions| bitfield on AXNodeData to allow a11y elements to indicate
which actions they actually support, and remove the |can_set_value| attribute
since we now have a general solution for all AXActions.

BUG=679247
==========

to

==========
Views a11y: Add AXNodeData.actions bitfield to indicate supported actions by UI.

AXActions are used to perform actions on an a11y element, such as changing the
value of a textfield, focus/blur an element, etc. However, currently there is no
way to indicate that an element actually supports that particular action, e.g.
a numerical combobox that allows text input may support three actions -
'left click' (to focus the text field), 'increment', and 'decrement', but might
not do anything on 'right click' (which would typically show a context menu).

Add a new |actions| bitfield on AXNodeData to allow a11y elements to indicate
which actions they actually support, and remove the |can_set_value| attribute
since we now have a general solution for all AXActions.

BUG=717846
==========

[Patti Lor, 2017-05-19 07:34:48]

Hi Dominic, PTAL? I've updated the CL description and bug too.

[dmazzoni, 2017-05-19 19:24:25]

lgtm

https://codereview.chromium.org/2799413002/diff/560001/content/browser/access...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

https://codereview.chromium.org/2799413002/diff/560001/content/browser/access...
content/browser/accessibility/browser_accessibility_cocoa.mm:2789: return
browserAccessibility_->HasAction(ui::AX_ACTION_SET_VALUE);
Love it, this is a lot cleaner!

[Patti Lor, 2017-05-22 00:20:57]

patricialor@chromium.org changed reviewers:
+ mkwst@chromium.org

[Patti Lor, 2017-05-22 00:20:59]

Thanks Dominic. PTAL mkwst@ for IPC stuff in:

chrome/common/extensions/chrome_extension_messages.h
content/common/accessibility_messages.h

Thanks in advance!

https://codereview.chromium.org/2799413002/diff/560001/content/browser/access...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

https://codereview.chromium.org/2799413002/diff/560001/content/browser/access...
content/browser/accessibility/browser_accessibility_cocoa.mm:2789: return
browserAccessibility_->HasAction(ui::AX_ACTION_SET_VALUE);
On 2017/05/19 19:24:25, dmazzoni wrote:
> Love it, this is a lot cleaner!

Yay :)

[Mike West, 2017-05-22 04:59:36]

LGTM

[Patti Lor, 2017-05-22 05:01:30]

The CQ bit was checked by patricialor@chromium.org

[commit-bot: I haz the power, 2017-05-22 05:01:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 06:24:26]

CQ is committing da patch.

Bot data: {"patchset_id": 560001, "attempt_start_ts": 1495429290756920,
"parent_rev": "04fa8149930e617b317c48d578fb2386c06e38c1", "commit_rev":
"979beede7c397098ba05931fd1f29792a95472eb"}

[commit-bot: I haz the power, 2017-05-22 06:24:50]

Description was changed from

==========
Views a11y: Add AXNodeData.actions bitfield to indicate supported actions by UI.

AXActions are used to perform actions on an a11y element, such as changing the
value of a textfield, focus/blur an element, etc. However, currently there is no
way to indicate that an element actually supports that particular action, e.g.
a numerical combobox that allows text input may support three actions -
'left click' (to focus the text field), 'increment', and 'decrement', but might
not do anything on 'right click' (which would typically show a context menu).

Add a new |actions| bitfield on AXNodeData to allow a11y elements to indicate
which actions they actually support, and remove the |can_set_value| attribute
since we now have a general solution for all AXActions.

BUG=717846
==========

to

==========
Views a11y: Add AXNodeData.actions bitfield to indicate supported actions by UI.

AXActions are used to perform actions on an a11y element, such as changing the
value of a textfield, focus/blur an element, etc. However, currently there is no
way to indicate that an element actually supports that particular action, e.g.
a numerical combobox that allows text input may support three actions -
'left click' (to focus the text field), 'increment', and 'decrement', but might
not do anything on 'right click' (which would typically show a context menu).

Add a new |actions| bitfield on AXNodeData to allow a11y elements to indicate
which actions they actually support, and remove the |can_set_value| attribute
since we now have a general solution for all AXActions.

BUG=717846

Review-Url: https://codereview.chromium.org/2799413002
Cr-Commit-Position: refs/heads/master@{#473515}
Committed:
https://chromium.googlesource.com/chromium/src/+/979beede7c397098ba05931fd1f2...
==========

[commit-bot: I haz the power, 2017-05-22 06:24:52]

Committed patchset #27 (id:560001) as
https://chromium.googlesource.com/chromium/src/+/979beede7c397098ba05931fd1f2...