Re-hook up surfaceRedrawNeededAsync callback.

Re-hook up surfaceRedrawNeededAsync callback.

This method was accidentally left unimplemented after
CompositorSurfaceManager was made the canonical SurfaceHolder.Callback2
implementation, leaving the CompositorView one dangling with no
callsites.  Because https://codereview.chromium.org/2201483002 also
changed it so that SurfaceViews are created later, at native library
load time, and always visible, bringing this back does not bring back
the black flicker associated with implementing this method on an
invisible View.  So we can safely reimplement it.

I changed CompositorView to inherit from a new interface because
surfaceRedrawNeededAsync is still not exposed in the SDK.

(In the future, we can also look into attaching the opaque SurfaceView
as early as possible -- instead of when the native library is loaded --
in order to avoid a flicker of View system content, given that this
callback should block the system from drawing until it's ready.)

BUG=512636
Review-Url: https://codereview.chromium.org/2893833005
Cr-Commit-Position: refs/heads/master@{#473414}
Committed: https://chromium.googlesource.com/chromium/src/+/5e7b4d978a2b9a272fecf89d28562e9b724f53e5

[aelias_OOO_until_Jul13, 2017-05-19 22:48:49]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[aelias_OOO_until_Jul13, 2017-05-19 22:48:58]

aelias@chromium.org changed reviewers:
+ boliu@chromium.org, changwan@chromium.org

[aelias_OOO_until_Jul13, 2017-05-19 22:49:13]

PTAL boliu@ for main review, changwan@ for OWNERS.

[commit-bot: I haz the power, 2017-05-19 22:49:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-05-19 23:04:19]

lgtm

[aelias_OOO_until_Jul13, 2017-05-19 23:07:54]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 23:08:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Changwan Ryu, 2017-05-19 23:11:22]

rubberstamp lgtm

[commit-bot: I haz the power, 2017-05-19 23:34:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 23:34:05]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[aelias_OOO_until_Jul13, 2017-05-19 23:41:22]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 23:41:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-05-19 23:46:50]

Description was changed from

==========
Re-hook up surfaceRedrawNeededAsync callback.

This method was accidentally left unimplemented after
CompositorSurfaceManager was made the canonical SurfaceHolder.Callback2
implementation, leaving the CompositorView one dangling with no
callsites.  Because https://codereview.chromium.org/2201483002 also
changed it so that SurfaceViews are created later, at native library
load time, and always visible, bringing this back does not bring back
the black flicker associated with implementing this method on an
invisible View.  So we can safely reimplement it.

I changed CompositorView no longer to inherit from
SurfaceHolder.Callback2 because surfaceRedrawNeededAsync is still not
exposed in the SDK.  CompositorSurfaceManager can just directly take a
CompositorView instead.

(In the future, we can also look into attaching the opaque SurfaceView
as early as possible -- instead of when the native library is loaded --
in order to avoid a flicker of View system content, given that this
callback should block the system from drawing until it's ready.)

BUG=512636
==========

to

==========
Re-hook up surfaceRedrawNeededAsync callback.

This method was accidentally left unimplemented after
CompositorSurfaceManager was made the canonical SurfaceHolder.Callback2
implementation, leaving the CompositorView one dangling with no
callsites.  Because https://codereview.chromium.org/2201483002 also
changed it so that SurfaceViews are created later, at native library
load time, and always visible, bringing this back does not bring back
the black flicker associated with implementing this method on an
invisible View.  So we can safely reimplement it.

I changed CompositorView to inherit from a new interface because
surfaceRedrawNeededAsync is still not exposed in the SDK.

(In the future, we can also look into attaching the opaque SurfaceView
as early as possible -- instead of when the native library is loaded --
in order to avoid a flicker of View system content, given that this
callback should block the system from drawing until it's ready.)

BUG=512636
==========

[aelias_OOO_until_Jul13, 2017-05-19 23:46:57]

Description was changed from

==========
Re-hook up surfaceRedrawNeededAsync callback.

This method was accidentally left unimplemented after
CompositorSurfaceManager was made the canonical SurfaceHolder.Callback2
implementation, leaving the CompositorView one dangling with no
callsites.  Because https://codereview.chromium.org/2201483002 also
changed it so that SurfaceViews are created later, at native library
load time, and always visible, bringing this back does not bring back
the black flicker associated with implementing this method on an
invisible View.  So we can safely reimplement it.

I changed CompositorView to inherit from a new interface because
surfaceRedrawNeededAsync is still not exposed in the SDK.

(In the future, we can also look into attaching the opaque SurfaceView
as early as possible -- instead of when the native library is loaded --
in order to avoid a flicker of View system content, given that this
callback should block the system from drawing until it's ready.)

BUG=512636
==========

to

==========
Re-hook up surfaceRedrawNeededAsync callback.

This method was accidentally left unimplemented after
CompositorSurfaceManager was made the canonical SurfaceHolder.Callback2
implementation, leaving the CompositorView one dangling with no
callsites.  Because https://codereview.chromium.org/2201483002 also
changed it so that SurfaceViews are created later, at native library
load time, and always visible, bringing this back does not bring back
the black flicker associated with implementing this method on an
invisible View.  So we can safely reimplement it.

I changed CompositorView to inherit from a new interface because
surfaceRedrawNeededAsync is still not exposed in the SDK.

(In the future, we can also look into attaching the opaque SurfaceView
as early as possible -- instead of when the native library is loaded --
in order to avoid a flicker of View system content, given that this
callback should block the system from drawing until it's ready.)

BUG=512636
==========

[aelias_OOO_until_Jul13, 2017-05-20 01:07:58]

The CQ bit was unchecked by aelias@chromium.org

[aelias_OOO_until_Jul13, 2017-05-20 01:08:00]

The CQ bit was checked by aelias@chromium.org

[aelias_OOO_until_Jul13, 2017-05-20 01:08:00]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org,
changwan@chromium.org
Link to the patchset: https://codereview.chromium.org/2893833005/#ps40001
(title: "Add another interface to fix unit test compile")

[commit-bot: I haz the power, 2017-05-20 01:08:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 04:43:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495242480089900,
"parent_rev": "b3b711c92dfc7033662f8ee048dd8a8bd5e88b16", "commit_rev":
"5e7b4d978a2b9a272fecf89d28562e9b724f53e5"}

[commit-bot: I haz the power, 2017-05-20 04:43:32]

Description was changed from

==========
Re-hook up surfaceRedrawNeededAsync callback.

This method was accidentally left unimplemented after
CompositorSurfaceManager was made the canonical SurfaceHolder.Callback2
implementation, leaving the CompositorView one dangling with no
callsites.  Because https://codereview.chromium.org/2201483002 also
changed it so that SurfaceViews are created later, at native library
load time, and always visible, bringing this back does not bring back
the black flicker associated with implementing this method on an
invisible View.  So we can safely reimplement it.

I changed CompositorView to inherit from a new interface because
surfaceRedrawNeededAsync is still not exposed in the SDK.

(In the future, we can also look into attaching the opaque SurfaceView
as early as possible -- instead of when the native library is loaded --
in order to avoid a flicker of View system content, given that this
callback should block the system from drawing until it's ready.)

BUG=512636
==========

to

==========
Re-hook up surfaceRedrawNeededAsync callback.

This method was accidentally left unimplemented after
CompositorSurfaceManager was made the canonical SurfaceHolder.Callback2
implementation, leaving the CompositorView one dangling with no
callsites.  Because https://codereview.chromium.org/2201483002 also
changed it so that SurfaceViews are created later, at native library
load time, and always visible, bringing this back does not bring back
the black flicker associated with implementing this method on an
invisible View.  So we can safely reimplement it.

I changed CompositorView to inherit from a new interface because
surfaceRedrawNeededAsync is still not exposed in the SDK.

(In the future, we can also look into attaching the opaque SurfaceView
as early as possible -- instead of when the native library is loaded --
in order to avoid a flicker of View system content, given that this
callback should block the system from drawing until it's ready.)

BUG=512636

Review-Url: https://codereview.chromium.org/2893833005
Cr-Commit-Position: refs/heads/master@{#473414}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e7b4d978a2b9a272fecf89d2856...
==========

[commit-bot: I haz the power, 2017-05-20 04:43:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5e7b4d978a2b9a272fecf89d2856...