Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2533)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java

Issue 2893833005: Re-hook up surfaceRedrawNeededAsync callback. (Closed)
Patch Set: Add another interface to fix unit test compile Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java
index 7f03c1deb50ea3ecd40f437617ace15be9b7f52a..e63d30a8499232ec5fb3d1e302183e79a26addc6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java
@@ -23,7 +23,6 @@ import android.widget.FrameLayout;
import org.chromium.base.TraceEvent;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
-import org.chromium.base.annotations.UsedByReflection;
import org.chromium.chrome.browser.compositor.layouts.Layout;
import org.chromium.chrome.browser.compositor.layouts.LayoutProvider;
import org.chromium.chrome.browser.compositor.layouts.LayoutRenderHost;
@@ -46,7 +45,8 @@ import java.util.List;
* The is the {@link View} displaying the ui compositor results; including webpages and tabswitcher.
*/
@JNINamespace("android")
-public class CompositorView extends FrameLayout implements SurfaceHolder.Callback2 {
+public class CompositorView
+ extends FrameLayout implements CompositorSurfaceManager.SurfaceHolderCallbackTarget {
private static final String TAG = "CompositorView";
private static final long NANOSECONDS_PER_MILLISECOND = 1000000;
@@ -251,12 +251,6 @@ public class CompositorView extends FrameLayout implements SurfaceHolder.Callbac
}
@Override
- public void surfaceRedrawNeeded(SurfaceHolder holder) {
- // Intentionally not implemented.
- }
-
- // TODO(boliu): Mark this override instead.
- @UsedByReflection("Android")
public void surfaceRedrawNeededAsync(SurfaceHolder holder, Runnable drawingFinished) {
if (mDrawingFinishedCallbacks == null) mDrawingFinishedCallbacks = new ArrayList<>();
mDrawingFinishedCallbacks.add(drawingFinished);

Powered by Google App Engine
This is Rietveld 408576698