Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp
diff --git a/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp b/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp
index f7384008f2a40670269bb597d33d834ddebf3e16..d42eca5de2751b90589e3e0e4c384f1ec9b8cb5e 100644
--- a/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp
+++ b/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp
@@ -59,7 +59,8 @@ class MockServiceWorkerContextClient : public WebServiceWorkerContextClient {
std::unique_ptr<WebServiceWorkerClientsCallbacks>) override {
NOTREACHED();
}
- void OpenWindow(const WebURL&,
+ void OpenWindow(const WebURL& redirect_url,
please use gerrit instead 2017/05/25 17:56:13 Here the parameter name does not really matter, IM
gogerald1 2017/05/29 22:13:16 Done.
+ const WebURL&,
std::unique_ptr<WebServiceWorkerClientCallbacks>) override {
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698