Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
index dbf6ed60ddf062dde123e9bd4961de008e1f7165..c368ccf3dfc1d4a9fedd7c55177416a0e125fae5 100644
--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
@@ -272,7 +272,8 @@ class WebServiceWorkerContextClient {
// should delete the callbacks after calling either onSuccess or onError.
// WebServiceWorkerClientInfo and WebServiceWorkerError ownerships are
// passed to the WebServiceWorkerClientsCallbacks implementation.
- virtual void OpenWindow(const WebURL&,
+ virtual void OpenWindow(const WebURL& redirect_url,
+ const WebURL&,
please use gerrit instead 2017/05/25 17:56:13 url_to_open
gogerald1 2017/05/29 22:13:16 Done.
std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0;
// A suggestion to cache this metadata in association with this URL.

Powered by Google App Engine
This is Rietveld 408576698