Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Side by Side Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)
Patch Set: address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "public/web/WebEmbeddedWorker.h" 5 #include "public/web/WebEmbeddedWorker.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include "platform/testing/URLTestHelpers.h" 8 #include "platform/testing/URLTestHelpers.h"
9 #include "platform/testing/UnitTestHelpers.h" 9 #include "platform/testing/UnitTestHelpers.h"
10 #include "platform/wtf/PtrUtil.h" 10 #include "platform/wtf/PtrUtil.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 has_associated_registration_ = has_associated_registration; 52 has_associated_registration_ = has_associated_registration;
53 } 53 }
54 void GetClient(const WebString&, 54 void GetClient(const WebString&,
55 std::unique_ptr<WebServiceWorkerClientCallbacks>) override { 55 std::unique_ptr<WebServiceWorkerClientCallbacks>) override {
56 NOTREACHED(); 56 NOTREACHED();
57 } 57 }
58 void GetClients(const WebServiceWorkerClientQueryOptions&, 58 void GetClients(const WebServiceWorkerClientQueryOptions&,
59 std::unique_ptr<WebServiceWorkerClientsCallbacks>) override { 59 std::unique_ptr<WebServiceWorkerClientsCallbacks>) override {
60 NOTREACHED(); 60 NOTREACHED();
61 } 61 }
62 void OpenWindow(const WebURL&, 62 void OpenWindow(const WebURL& redirect_url,
please use gerrit instead 2017/05/25 17:56:13 Here the parameter name does not really matter, IM
gogerald1 2017/05/29 22:13:16 Done.
63 const WebURL&,
63 std::unique_ptr<WebServiceWorkerClientCallbacks>) override { 64 std::unique_ptr<WebServiceWorkerClientCallbacks>) override {
64 NOTREACHED(); 65 NOTREACHED();
65 } 66 }
66 void PostMessageToClient(const WebString& uuid, 67 void PostMessageToClient(const WebString& uuid,
67 const WebString&, 68 const WebString&,
68 WebMessagePortChannelArray) override { 69 WebMessagePortChannelArray) override {
69 NOTREACHED(); 70 NOTREACHED();
70 } 71 }
71 void SkipWaiting( 72 void SkipWaiting(
72 std::unique_ptr<WebServiceWorkerSkipWaitingCallbacks>) override { 73 std::unique_ptr<WebServiceWorkerSkipWaitingCallbacks>) override {
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 ::testing::Mock::VerifyAndClearExpectations(mock_client_); 302 ::testing::Mock::VerifyAndClearExpectations(mock_client_);
302 303
303 // Resume after download. 304 // Resume after download.
304 EXPECT_CALL(*mock_client_, CreateServiceWorkerProviderProxy()) 305 EXPECT_CALL(*mock_client_, CreateServiceWorkerProviderProxy())
305 .WillOnce(::testing::Return(nullptr)); 306 .WillOnce(::testing::Return(nullptr));
306 worker_->ResumeAfterDownload(); 307 worker_->ResumeAfterDownload();
307 ::testing::Mock::VerifyAndClearExpectations(mock_client_); 308 ::testing::Mock::VerifyAndClearExpectations(mock_client_);
308 } 309 }
309 310
310 } // namespace blink 311 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698