Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h
diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h
index d1f23fa897fe0a2f5f32fd0c4d284157d783af54..439498ab84284e9a108fc20cc945f26e59f4f35f 100644
--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h
+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h
@@ -56,7 +56,8 @@ class ServiceWorkerGlobalScopeClientImpl final
std::unique_ptr<WebServiceWorkerClientCallbacks>) override;
void GetClients(const WebServiceWorkerClientQueryOptions&,
std::unique_ptr<WebServiceWorkerClientsCallbacks>) override;
- void OpenWindow(const WebURL&,
+ void OpenWindow(const WebURL& redirect_url,
+ const WebURL&,
please use gerrit instead 2017/05/25 17:56:13 url_to_open
gogerald1 2017/05/29 22:13:16 Done.
std::unique_ptr<WebServiceWorkerClientCallbacks>) override;
void SetCachedMetadata(const WebURL&, const char*, size_t) override;
void ClearCachedMetadata(const WebURL&) override;

Powered by Google App Engine
This is Rietveld 408576698