[Payments] Implement openWindow for service worker based payment handler

third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 51 matching lines @@
 
  public:
   virtual ~ServiceWorkerGlobalScopeClient() {}
 
   // Called from ServiceWorkerClients.
   virtual void GetClient(const WebString&,
                          std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0;
   virtual void GetClients(
       const WebServiceWorkerClientQueryOptions&,
       std::unique_ptr<WebServiceWorkerClientsCallbacks>) = 0;
-  virtual void OpenWindow(const WebURL&,
+  virtual void OpenWindow(const WebURL& redirect_url,

[zino, 2017/05/25 17:02:42]

It might be better to add a new method (e.g. OpenWindowForPaymentHandler) and
share the implementation with clients.openWindow. (If the redirect_url is not
used in clients.openWindow)

[please use gerrit instead, 2017/05/25 17:56:13]

+1

[gogerald1, 2017/05/29 22:13:16]

Done.

+                          const WebURL&,
                           std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0;
   virtual void SetCachedMetadata(const WebURL&, const char*, size_t) = 0;
   virtual void ClearCachedMetadata(const WebURL&) = 0;
 
   virtual WebURL Scope() const = 0;
 
   virtual void DidHandleActivateEvent(int event_id,
                                       WebServiceWorkerEventResult,
                                       double event_dispatch_time) = 0;
   virtual void DidHandleBackgroundFetchAbortEvent(
@@ skipping 73 matching lines @@
   ServiceWorkerGlobalScopeClient() {}
 };
 
 MODULES_EXPORT void ProvideServiceWorkerGlobalScopeClientToWorker(
     WorkerClients*,
     ServiceWorkerGlobalScopeClient*);
 
 }  // namespace blink
 
 #endif  // ServiceWorkerGlobalScopeClient_h