third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h - Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)

Patch Set: format Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.h ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h » ('j') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

index 43c4452e105d4e2eceee39aeaea7fd41a7f49055..db7e1d62a0c349a031617fb5585e980920cf0294 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

@@ -70,6 +70,7 @@ class MODULES_EXPORT ServiceWorkerGlobalScopeClient

const WebServiceWorkerClientQueryOptions&,

std::unique_ptr<WebServiceWorkerClientsCallbacks>) = 0;

virtual void OpenWindow(const WebURL&,

+ const WebURL&,

please use gerrit instead 2017/05/25 14:53:27 Need parameter names here.

gogerald1 2017/05/25 16:53:32 Done.

std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0;

virtual void SetCachedMetadata(const WebURL&, const char*, size_t) = 0;

virtual void ClearCachedMetadata(const WebURL&) = 0;