third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h - Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)

Patch Set: format Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

index d1f23fa897fe0a2f5f32fd0c4d284157d783af54..6ca4a3c50a9412df88d5ffaf73145b709d12f14e 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

@@ -57,6 +57,7 @@ class ServiceWorkerGlobalScopeClientImpl final

void GetClients(const WebServiceWorkerClientQueryOptions&,

std::unique_ptr<WebServiceWorkerClientsCallbacks>) override;

void OpenWindow(const WebURL&,

+ const WebURL&,

please use gerrit instead 2017/05/25 14:53:27 Need parameter names.

gogerald1 2017/05/25 16:53:33 Done.

std::unique_ptr<WebServiceWorkerClientCallbacks>) override;

void SetCachedMetadata(const WebURL&, const char*, size_t) override;

void ClearCachedMetadata(const WebURL&) override;