[CSS Typed OM] Make CSSKeywordValue's value attribute mutable

Make CSSKeywordValue's value attribute mutable

Also update the attribute name to "value" to match the spec, and
change the type to a plain String, to avoid interning random
developer strings inside AtomicString when we don't need to.

In the original spec for Typed OM, every StyleValue subclass was 
immutable, so you'd need to create new ones if you wanted to udpate
something. It turns out that this can be expensive due to garbage 
collection churn, and it's now been changed so that StyleValue 
subclasses are mutable.

CSSKeywordValue spec (note no "readonly" keyword on value now)
https://drafts.css-houdini.org/css-typed-om/#csskeywordvalue

BUG=545318
Review-Url: https://codereview.chromium.org/2893823002
Cr-Commit-Position: refs/heads/master@{#474962}
Committed: https://chromium.googlesource.com/chromium/src/+/2656da0429614ad0134c22e9695a619907d11a78

[meade_UTC10, 2017-05-18 03:49:30]

Description was changed from

==========
Make CSSKeywordValue mutable

BUG=545318
==========

to

==========
Make CSSKeywordValue mutable

In the original spec for Typed OM, every StyleValue subclass was 
immutable, so you'd need to create new ones if you wanted to udpate
something. It turns out that this can be expensive due to garbage 
collection churn, and it's now been changed so that StyleValue 
subclasses are mutable.

BUG=545318
==========

[meade_UTC10, 2017-05-18 03:49:55]

meade@chromium.org changed reviewers:
+ bugsnash@chromium.org

[meade_UTC10, 2017-05-18 03:49:55]

Hey Bugs! Want to be first review on this one?

[meade_UTC10, 2017-05-18 03:50:51]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 03:51:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meade_UTC10, 2017-05-18 03:54:28]

Description was changed from

==========
Make CSSKeywordValue mutable

In the original spec for Typed OM, every StyleValue subclass was 
immutable, so you'd need to create new ones if you wanted to udpate
something. It turns out that this can be expensive due to garbage 
collection churn, and it's now been changed so that StyleValue 
subclasses are mutable.

BUG=545318
==========

to

==========
Make CSSKeywordValue's value attribute mutable

Also update the attribute name to "value" to match the spec.

In the original spec for Typed OM, every StyleValue subclass was 
immutable, so you'd need to create new ones if you wanted to udpate
something. It turns out that this can be expensive due to garbage 
collection churn, and it's now been changed so that StyleValue 
subclasses are mutable.

BUG=545318
==========

[meade_UTC10, 2017-05-18 03:54:38]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 03:55:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 04:10:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 04:10:17]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Bugs Nash, 2017-05-19 00:16:46]

On 2017/05/18 at 03:49:55, meade wrote:
> Hey Bugs! Want to be first review on this one?

Sure do! I'm not very familiar with typed om so bear with me...

Could you please link the spec in the description where you say 'to match the
spec'?

Is there a spec for being able to mutate the KeywordValue?

Does this change impact generated code?

[meade_UTC10, 2017-05-25 05:11:28]

Description was changed from

==========
Make CSSKeywordValue's value attribute mutable

Also update the attribute name to "value" to match the spec.

In the original spec for Typed OM, every StyleValue subclass was 
immutable, so you'd need to create new ones if you wanted to udpate
something. It turns out that this can be expensive due to garbage 
collection churn, and it's now been changed so that StyleValue 
subclasses are mutable.

BUG=545318
==========

to

==========
Make CSSKeywordValue's value attribute mutable

Also update the attribute name to "value" to match the spec.

In the original spec for Typed OM, every StyleValue subclass was 
immutable, so you'd need to create new ones if you wanted to udpate
something. It turns out that this can be expensive due to garbage 
collection churn, and it's now been changed so that StyleValue 
subclasses are mutable.

CSSKeywordValue spec (note no "mutable" keyword on value now)
https://drafts.css-houdini.org/css-typed-om/#csskeywordvalue

BUG=545318
==========

[meade_UTC10, 2017-05-25 05:13:12]

On 2017/05/19 00:16:46, Bugs Nash wrote:
> On 2017/05/18 at 03:49:55, meade wrote:
> > Hey Bugs! Want to be first review on this one?
> 
> Sure do! I'm not very familiar with typed om so bear with me...
> 
> Could you please link the spec in the description where you say 'to match the
> spec'?
> 
> Is there a spec for being able to mutate the KeywordValue?
> 
> Does this change impact generated code?

Updated the CL description to show the current spec. The actual behaviour of the
setter is now apparently going to be what's in my CL, but the spec hasn't been
updated yet (see issue 14). I'm going to hold off implementing the more
complicated thing that's in the spec until it settles down.

There is no change to any generated code we care about.

[meade_UTC10, 2017-05-25 05:16:21]

Description was changed from

==========
Make CSSKeywordValue's value attribute mutable

Also update the attribute name to "value" to match the spec.

In the original spec for Typed OM, every StyleValue subclass was 
immutable, so you'd need to create new ones if you wanted to udpate
something. It turns out that this can be expensive due to garbage 
collection churn, and it's now been changed so that StyleValue 
subclasses are mutable.

CSSKeywordValue spec (note no "mutable" keyword on value now)
https://drafts.css-houdini.org/css-typed-om/#csskeywordvalue

BUG=545318
==========

to

==========
Make CSSKeywordValue's value attribute mutable

Also update the attribute name to "value" to match the spec, and
change the type to a plain String, to avoid interning random
developer strings inside AtomicString when we don't need to.

In the original spec for Typed OM, every StyleValue subclass was 
immutable, so you'd need to create new ones if you wanted to udpate
something. It turns out that this can be expensive due to garbage 
collection churn, and it's now been changed so that StyleValue 
subclasses are mutable.

CSSKeywordValue spec (note no "mutable" keyword on value now)
https://drafts.css-houdini.org/css-typed-om/#csskeywordvalue

BUG=545318
==========

[meade_UTC10, 2017-05-25 05:16:48]

Description was changed from

==========
Make CSSKeywordValue's value attribute mutable

Also update the attribute name to "value" to match the spec, and
change the type to a plain String, to avoid interning random
developer strings inside AtomicString when we don't need to.

In the original spec for Typed OM, every StyleValue subclass was 
immutable, so you'd need to create new ones if you wanted to udpate
something. It turns out that this can be expensive due to garbage 
collection churn, and it's now been changed so that StyleValue 
subclasses are mutable.

CSSKeywordValue spec (note no "mutable" keyword on value now)
https://drafts.css-houdini.org/css-typed-om/#csskeywordvalue

BUG=545318
==========

to

==========
Make CSSKeywordValue's value attribute mutable

Also update the attribute name to "value" to match the spec, and
change the type to a plain String, to avoid interning random
developer strings inside AtomicString when we don't need to.

In the original spec for Typed OM, every StyleValue subclass was 
immutable, so you'd need to create new ones if you wanted to udpate
something. It turns out that this can be expensive due to garbage 
collection churn, and it's now been changed so that StyleValue 
subclasses are mutable.

CSSKeywordValue spec (note no "readonly" keyword on value now)
https://drafts.css-houdini.org/css-typed-om/#csskeywordvalue

BUG=545318
==========

[Bugs Nash, 2017-05-25 23:32:12]

On 2017/05/25 at 05:13:12, meade wrote:
> On 2017/05/19 00:16:46, Bugs Nash wrote:
> > On 2017/05/18 at 03:49:55, meade wrote:
> > > Hey Bugs! Want to be first review on this one?
> > 
> > Sure do! I'm not very familiar with typed om so bear with me...
> > 
> > Could you please link the spec in the description where you say 'to match
the
> > spec'?
> > 
> > Is there a spec for being able to mutate the KeywordValue?
> > 
> > Does this change impact generated code?
> 
> Updated the CL description to show the current spec. The actual behaviour of
the setter is now apparently going to be what's in my CL, but the spec hasn't
been updated yet (see issue 14). I'm going to hold off implementing the more
complicated thing that's in the spec until it settles down.
> 
> There is no change to any generated code we care about.

Excellent that answers all questions, lgtm

[meade_UTC10, 2017-05-26 01:23:10]

The CQ bit was checked by meade@chromium.org

[commit-bot: I haz the power, 2017-05-26 01:24:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 03:11:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 03:11:24]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[meade_UTC10, 2017-05-26 03:54:35]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-05-26 03:54:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2893823002/#ps80001
(title: "Update global interface listing Layout tests")

[commit-bot: I haz the power, 2017-05-26 03:55:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 06:00:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 06:00:43]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[meade_UTC10, 2017-05-26 06:37:10]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-05-26 06:37:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2893823002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-26 06:37:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 08:13:52]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495780630281160,
"parent_rev": "c378166dd1a360be0ccf9359631e5765dc544209", "commit_rev":
"2656da0429614ad0134c22e9695a619907d11a78"}

[commit-bot: I haz the power, 2017-05-26 08:14:03]

Description was changed from

==========
Make CSSKeywordValue's value attribute mutable

Also update the attribute name to "value" to match the spec, and
change the type to a plain String, to avoid interning random
developer strings inside AtomicString when we don't need to.

In the original spec for Typed OM, every StyleValue subclass was 
immutable, so you'd need to create new ones if you wanted to udpate
something. It turns out that this can be expensive due to garbage 
collection churn, and it's now been changed so that StyleValue 
subclasses are mutable.

CSSKeywordValue spec (note no "readonly" keyword on value now)
https://drafts.css-houdini.org/css-typed-om/#csskeywordvalue

BUG=545318
==========

to

==========
Make CSSKeywordValue's value attribute mutable

Also update the attribute name to "value" to match the spec, and
change the type to a plain String, to avoid interning random
developer strings inside AtomicString when we don't need to.

In the original spec for Typed OM, every StyleValue subclass was 
immutable, so you'd need to create new ones if you wanted to udpate
something. It turns out that this can be expensive due to garbage 
collection churn, and it's now been changed so that StyleValue 
subclasses are mutable.

CSSKeywordValue spec (note no "readonly" keyword on value now)
https://drafts.css-houdini.org/css-typed-om/#csskeywordvalue

BUG=545318

Review-Url: https://codereview.chromium.org/2893823002
Cr-Commit-Position: refs/heads/master@{#474962}
Committed:
https://chromium.googlesource.com/chromium/src/+/2656da0429614ad0134c22e9695a...
==========

[commit-bot: I haz the power, 2017-05-26 08:14:04]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/2656da0429614ad0134c22e9695a...