Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h

Issue 2893823002: [CSS Typed OM] Make CSSKeywordValue's value attribute mutable (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h b/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h
index 1378b0a6af46c3127acff6ce8ca0aca3a7bde371..632aaef7de8d3e601f6924010077a9cc547b0dba 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h
@@ -8,7 +8,6 @@
#include "core/CSSValueKeywords.h"
#include "core/CoreExport.h"
#include "core/css/cssom/CSSStyleValue.h"
-#include "platform/wtf/text/AtomicString.h"
namespace blink {
@@ -19,22 +18,22 @@ class CORE_EXPORT CSSKeywordValue final : public CSSStyleValue {
DEFINE_WRAPPERTYPEINFO();
public:
- static CSSKeywordValue* Create(const AtomicString& keyword);
- static CSSKeywordValue* Create(const AtomicString& keyword, ExceptionState&);
+ static CSSKeywordValue* Create(const String& keyword);
+ static CSSKeywordValue* Create(const String& keyword, ExceptionState&);
static CSSKeywordValue* FromCSSValue(const CSSValue&);
StyleValueType GetType() const override { return kKeywordType; }
- const AtomicString& keywordValue() const;
+ const String& value() const;
+ void setValue(const String& keyword) { keyword_value_ = keyword; }
CSSValueID KeywordValueID() const;
CSSValue* ToCSSValue() const override;
private:
- explicit CSSKeywordValue(const AtomicString& keyword)
- : keyword_value_(keyword) {}
+ explicit CSSKeywordValue(const String& keyword) : keyword_value_(keyword) {}
- AtomicString keyword_value_;
+ String keyword_value_;
};
DEFINE_TYPE_CASTS(CSSKeywordValue,

Powered by Google App Engine
This is Rietveld 408576698