Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 289373007: Rename MetricsServiceHelper to ChromeMetricsServiceAccessor. (Closed)

Created:
6 years, 7 months ago by motek.
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang, Ilya Sherman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Rename MetricsServiceHelper to ChromeMetricsServiceAccessor. Dependencies updated. BUG=374202 R=isherman@chromium.org, thestig@chromium.org TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272234

Patch Set 1 #

Patch Set 2 : After rebase. #

Patch Set 3 : Rebase again. #

Total comments: 9

Patch Set 4 : Addressed review comments. #

Patch Set 5 : A review update. #

Patch Set 6 : Resynced. #

Patch Set 7 : Fixed a merge conflict. #

Patch Set 8 : Another rebas. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -161 lines) Patch
M chrome/browser/chrome_browser_metrics_service_observer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/manifest_fetch_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/browser/metrics/chrome_metrics_service_accessor.h View 1 2 3 4 1 chunk +73 lines, -0 lines 0 comments Download
A chrome/browser/metrics/chrome_metrics_service_accessor.cc View 1 2 3 4 1 chunk +63 lines, -0 lines 0 comments Download
A chrome/browser/metrics/chrome_metrics_service_accessor_unittest.cc View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 2 3 4 5 6 7 5 chunks +1 line, -59 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -48 lines 0 comments Download
M chrome/browser/metrics/metrics_service_unittest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/crashes_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
motek.
Could I bother you for a review? I am about to build a new one ...
6 years, 7 months ago (2014-05-20 14:52:10 UTC) #1
Ilya Sherman
https://codereview.chromium.org/289373007/diff/40001/chrome/browser/metrics/chrome_metrics_service_accessor.h File chrome/browser/metrics/chrome_metrics_service_accessor.h (right): https://codereview.chromium.org/289373007/diff/40001/chrome/browser/metrics/chrome_metrics_service_accessor.h#newcode9 chrome/browser/metrics/chrome_metrics_service_accessor.h:9: #include "chrome/browser/metrics/metrics_service_observer.h" nit: This file has moved; you'll need ...
6 years, 7 months ago (2014-05-20 15:18:11 UTC) #2
motek.
https://codereview.chromium.org/289373007/diff/40001/chrome/browser/metrics/chrome_metrics_service_accessor.h File chrome/browser/metrics/chrome_metrics_service_accessor.h (right): https://codereview.chromium.org/289373007/diff/40001/chrome/browser/metrics/chrome_metrics_service_accessor.h#newcode9 chrome/browser/metrics/chrome_metrics_service_accessor.h:9: #include "chrome/browser/metrics/metrics_service_observer.h" On 2014/05/20 15:18:11, Ilya Sherman wrote: > ...
6 years, 7 months ago (2014-05-20 15:54:38 UTC) #3
Ilya Sherman
https://codereview.chromium.org/289373007/diff/40001/chrome/browser/metrics/chrome_metrics_service_accessor.h File chrome/browser/metrics/chrome_metrics_service_accessor.h (right): https://codereview.chromium.org/289373007/diff/40001/chrome/browser/metrics/chrome_metrics_service_accessor.h#newcode9 chrome/browser/metrics/chrome_metrics_service_accessor.h:9: #include "chrome/browser/metrics/metrics_service_observer.h" On 2014/05/20 15:54:39, motek. wrote: > On ...
6 years, 7 months ago (2014-05-20 15:56:44 UTC) #4
motek.
On 2014/05/20 15:56:44, Ilya Sherman wrote: > https://codereview.chromium.org/289373007/diff/40001/chrome/browser/metrics/chrome_metrics_service_accessor.h > File chrome/browser/metrics/chrome_metrics_service_accessor.h (right): > > https://codereview.chromium.org/289373007/diff/40001/chrome/browser/metrics/chrome_metrics_service_accessor.h#newcode9 ...
6 years, 7 months ago (2014-05-20 16:16:24 UTC) #5
Ilya Sherman
LGTM, thanks.
6 years, 7 months ago (2014-05-20 22:35:28 UTC) #6
Ilya Sherman
TBR Lei for mechanical refactoring changes outside of //chrome/browser/metrics
6 years, 7 months ago (2014-05-20 22:36:34 UTC) #7
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-20 22:36:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/289373007/80001
6 years, 7 months ago (2014-05-20 22:38:23 UTC) #9
Lei Zhang
lgtm
6 years, 7 months ago (2014-05-20 22:45:40 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 06:43:24 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-21 20:04:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155577)
6 years, 7 months ago (2014-05-21 20:05:00 UTC) #13
motek.
The CQ bit was checked by motek@chromium.org
6 years, 7 months ago (2014-05-22 08:22:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/289373007/100001
6 years, 7 months ago (2014-05-22 08:26:37 UTC) #15
motek.
The CQ bit was unchecked by motek@chromium.org
6 years, 7 months ago (2014-05-22 09:44:02 UTC) #16
motek.
The CQ bit was checked by motek@chromium.org
6 years, 7 months ago (2014-05-22 09:46:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/289373007/120001
6 years, 7 months ago (2014-05-22 09:47:15 UTC) #18
motek.
The CQ bit was checked by motek@chromium.org
6 years, 7 months ago (2014-05-22 15:35:30 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/289373007/140001
6 years, 7 months ago (2014-05-22 15:37:56 UTC) #20
motek.
6 years, 7 months ago (2014-05-22 18:08:18 UTC) #21
Message was sent while issue was closed. 
Committed patchset #8 manually as r272234 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698