Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: chrome/browser/extensions/updater/manifest_fetch_data.cc

Issue 289373007: Rename MetricsServiceHelper to ChromeMetricsServiceAccessor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another rebas. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/updater/manifest_fetch_data.h" 5 #include "chrome/browser/extensions/updater/manifest_fetch_data.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
11 #include "base/strings/string_number_conversions.h" 11 #include "base/strings/string_number_conversions.h"
12 #include "base/strings/string_util.h" 12 #include "base/strings/string_util.h"
13 #include "chrome/browser/google/google_util.h" 13 #include "chrome/browser/google/google_util.h"
14 #include "chrome/browser/metrics/metrics_service.h" 14 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
15 #include "chrome/browser/omaha_query_params/omaha_query_params.h" 15 #include "chrome/browser/omaha_query_params/omaha_query_params.h"
16 #include "net/base/escape.h" 16 #include "net/base/escape.h"
17 17
18 namespace { 18 namespace {
19 19
20 // Maximum length of an extension manifest update check url, since it is a GET 20 // Maximum length of an extension manifest update check url, since it is a GET
21 // request. We want to stay under 2K because of proxies, etc. 21 // request. We want to stay under 2K because of proxies, etc.
22 const int kExtensionsManifestMaxURLSize = 2000; 22 const int kExtensionsManifestMaxURLSize = 2000;
23 23
24 } // namespace 24 } // namespace
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 parts.push_back("brand=" + brand); 96 parts.push_back("brand=" + brand);
97 #endif 97 #endif
98 98
99 std::string ping_value; 99 std::string ping_value;
100 pings_[id] = PingData(0, 0, false); 100 pings_[id] = PingData(0, 0, false);
101 101
102 if (ping_data) { 102 if (ping_data) {
103 if (ping_data->rollcall_days == kNeverPinged || 103 if (ping_data->rollcall_days == kNeverPinged ||
104 ping_data->rollcall_days > 0) { 104 ping_data->rollcall_days > 0) {
105 ping_value += "r=" + base::IntToString(ping_data->rollcall_days); 105 ping_value += "r=" + base::IntToString(ping_data->rollcall_days);
106 if (MetricsServiceHelper::IsMetricsReportingEnabled()) { 106 if (ChromeMetricsServiceAccessor::IsMetricsReportingEnabled()) {
107 ping_value += "&e=" + std::string(ping_data->is_enabled ? "1" : "0"); 107 ping_value += "&e=" + std::string(ping_data->is_enabled ? "1" : "0");
108 } 108 }
109 pings_[id].rollcall_days = ping_data->rollcall_days; 109 pings_[id].rollcall_days = ping_data->rollcall_days;
110 pings_[id].is_enabled = ping_data->is_enabled; 110 pings_[id].is_enabled = ping_data->is_enabled;
111 } 111 }
112 if (ping_data->active_days == kNeverPinged || 112 if (ping_data->active_days == kNeverPinged ||
113 ping_data->active_days > 0) { 113 ping_data->active_days > 0) {
114 if (!ping_value.empty()) 114 if (!ping_value.empty())
115 ping_value += "&"; 115 ping_value += "&";
116 ping_value += "a=" + base::IntToString(ping_data->active_days); 116 ping_value += "a=" + base::IntToString(ping_data->active_days);
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 NOTREACHED(); 156 NOTREACHED();
157 return value == kNeverPinged || value > 0; 157 return value == kNeverPinged || value > 0;
158 } 158 }
159 159
160 void ManifestFetchData::Merge(const ManifestFetchData& other) { 160 void ManifestFetchData::Merge(const ManifestFetchData& other) {
161 DCHECK(full_url() == other.full_url()); 161 DCHECK(full_url() == other.full_url());
162 request_ids_.insert(other.request_ids_.begin(), other.request_ids_.end()); 162 request_ids_.insert(other.request_ids_.begin(), other.request_ids_.end());
163 } 163 }
164 164
165 } // namespace extensions 165 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698