Rename MetricsServiceHelper to ChromeMetricsServiceAccessor.

chrome/browser/metrics/chrome_metrics_service_accessor.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_ACCESSOR_H_
+#define CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_ACCESSOR_H_
+
+#include "base/gtest_prod_util.h"
+#include "chrome/browser/metrics/metrics_service_observer.h"

[Ilya Sherman, 2014/05/20 15:18:11]

nit: This file has moved; you'll need to update the path.

[Ilya Sherman, 2014/05/20 15:18:11]

nit: Can this class be forward-declared, and the #include moved into the .cc
file?

[motek., 2014/05/20 15:54:39]

Done.

[motek., 2014/05/20 15:54:39]

It would appear that it cannot on the account of DISALLOW_IMPLICIT_CONSTRUCTORS.
It results in a compilation error:
ISO C++ forbids declaration of ‘DISALLOW_IMPLICIT_CONSTRUCTORS’ with no type
[-fpermissive]

[Ilya Sherman, 2014/05/20 15:56:44]

For that macro, you can "#include base/macros.h" instead.

+
+class ChromeBrowserMetricsServiceObserver;
+class Profile;
+
+namespace {
+class CrashesDOMHandler;
+class FlashDOMHandler;
+}
+
+namespace extensions {
+class ExtensionDownloader;
+class ManifestFetchData;
+class MetricsPrivateGetIsCrashReportingEnabledFunction;
+}
+
+namespace prerender {
+bool IsOmniboxEnabled(Profile* profile);
+}
+
+namespace system_logs {
+class ChromeInternalLogSource;
+}
+
+// This class limits and documents access to metrics service helper methods.
+// Since these methods are private, each user has to be explicitly declared
+// as a 'friend' below.
+class ChromeMetricsServiceAccessor {
+ private:
+  friend bool prerender::IsOmniboxEnabled(Profile* profile);
+  friend class ::ChromeBrowserMetricsServiceObserver;
+  friend class ChromeRenderMessageFilter;
+  friend class ::CrashesDOMHandler;
+  friend class extensions::ExtensionDownloader;
+  friend class extensions::ManifestFetchData;
+  friend class extensions::MetricsPrivateGetIsCrashReportingEnabledFunction;
+  friend class ::FlashDOMHandler;
+  friend class system_logs::ChromeInternalLogSource;
+
+  FRIEND_TEST_ALL_PREFIXES(ChromeMetricsServiceAccessorTest,
+                           MetricsReportingEnabled);
+  FRIEND_TEST_ALL_PREFIXES(ChromeMetricsServiceAccessorTest,
+                           CrashReportingEnabled);
+
+  // Returns true if prefs::kMetricsReportingEnabled is set.
+  // TODO(asvitkine): Consolidate the method in MetricsStateManager.
+  // TODO(asvitkine): This function does not report the correct value on
+  // Android and ChromeOS, see http://crbug.com/362192.
+  static bool IsMetricsReportingEnabled();
+
+  // Returns true if crash reporting is enabled.  This is set at the platform
+  // level for Android and ChromeOS, and otherwise is the same as
+  // IsMetricsReportingEnabled for desktop Chrome.
+  static bool IsCrashReportingEnabled();
+
+  // Registers/unregisters |observer| to receive MetricsLog notifications
+  // from metrics service.
+  static void AddMetricsServiceObserver(MetricsServiceObserver* observer);
+  static void RemoveMetricsServiceObserver(MetricsServiceObserver* observer);
+
+  DISALLOW_IMPLICIT_CONSTRUCTORS(ChromeMetricsServiceAccessor);
+};
+
+#endif  // CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_ACCESSOR_H_