Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2893613002: PlzNavigate: Fix "Only one CSP is reported instead of several". (Closed)

Created:
3 years, 7 months ago by arthursonzogni
Modified:
3 years, 7 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, clamy, darin-cc_chromium.org, jam, nasko
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Fix "Only one CSP is reported instead of several". This CL makes that every infringed policy are reported instead of the infringed first one. One unit test is added as well. TEST=external/wpt/content-security-policy/frame-src/frame-src-redirect.html BUG=723602 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel;master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2893613002 Cr-Commit-Position: refs/heads/master@{#473580} Committed: https://chromium.googlesource.com/chromium/src/+/2c1e5408c1f8e69ae1891edb22a8502b13880846

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -29 lines) Patch
M content/common/content_security_policy/content_security_policy_unittest.cc View 7 chunks +12 lines, -8 lines 0 comments Download
M content/common/content_security_policy/csp_context.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/content_security_policy/csp_context_unittest.cc View 4 chunks +44 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (19 generated)
arthursonzogni
Hi Mike, Please take a look.
3 years, 7 months ago (2017-05-17 16:31:52 UTC) #10
Mike West
LGTM!
3 years, 7 months ago (2017-05-22 08:15:14 UTC) #13
arthursonzogni
Thanks!
3 years, 7 months ago (2017-05-22 14:22:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893613002/20001
3 years, 7 months ago (2017-05-22 14:22:55 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 15:34:19 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2c1e5408c1f8e69ae1891edb22a8...

Powered by Google App Engine
This is Rietveld 408576698