Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2893563002:
PlzNavigate: Add flag expectations for several regressions. (Closed)
|
Created:
3 years, 7 months ago by arthursonzogni Modified:
3 years, 7 months ago Reviewers:
clamy CC:
chromium-reviews, blink-reviews, nasko Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionPlzNavigate: Add webkit layout test TestExpectations.
Several regressions happened with PlzNavigate.
This CL updates the
Webkit/LayoutTests/FlagExpectations/enable-browser-side-navigation file.
BUG=723595, 723602, 713388, 724989
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel;master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2893563002
Cr-Commit-Position: refs/heads/master@{#473574}
Committed: https://chromium.googlesource.com/chromium/src/+/102feab6fd73e6b0510c572165d10e2b3831790c
Patch Set 1 #Patch Set 2 : Merge conflict => Rebase. #Patch Set 3 : Add on more regression. #
Dependent Patchsets: Messages
Total messages: 26 (20 generated)
The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== PlzNavigate: add webkit layout test TestExpectations. Several regressions happened with PlzNavigate. This CL updates the Webkit/LayoutTests/FlagExpectations/enable-browser-side-navigation file. BUG=723595, 723602, 713388 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel;master.tryserver.chromium.linux:linux_site_isolation ========== to ========== PlzNavigate: Add webkit layout test TestExpectations. Several regressions happened with PlzNavigate. This CL updates the Webkit/LayoutTests/FlagExpectations/enable-browser-side-navigation file. BUG=723595, 723602, 713388 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel;master.tryserver.chromium.linux:linux_site_isolation ==========
arthursonzogni@chromium.org changed reviewers: + clamy@chromium.org
Hi Camille, Please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #3 (id:60001) has been deleted
One more regression added to the list.
The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== PlzNavigate: Add webkit layout test TestExpectations. Several regressions happened with PlzNavigate. This CL updates the Webkit/LayoutTests/FlagExpectations/enable-browser-side-navigation file. BUG=723595, 723602, 713388 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel;master.tryserver.chromium.linux:linux_site_isolation ========== to ========== PlzNavigate: Add webkit layout test TestExpectations. Several regressions happened with PlzNavigate. This CL updates the Webkit/LayoutTests/FlagExpectations/enable-browser-side-navigation file. BUG=723595, 723602, 713388, 724989 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel;master.tryserver.chromium.linux:linux_site_isolation ==========
Thanks! Lgtm.
The CQ bit was checked by arthursonzogni@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks!
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495462566832020,
"parent_rev": "b927623189939cb6ecef5c12565ef7b151359c2c", "commit_rev":
"102feab6fd73e6b0510c572165d10e2b3831790c"}
Message was sent while issue was closed.
Description was changed from ========== PlzNavigate: Add webkit layout test TestExpectations. Several regressions happened with PlzNavigate. This CL updates the Webkit/LayoutTests/FlagExpectations/enable-browser-side-navigation file. BUG=723595, 723602, 713388, 724989 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel;master.tryserver.chromium.linux:linux_site_isolation ========== to ========== PlzNavigate: Add webkit layout test TestExpectations. Several regressions happened with PlzNavigate. This CL updates the Webkit/LayoutTests/FlagExpectations/enable-browser-side-navigation file. BUG=723595, 723602, 713388, 724989 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel;master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2893563002 Cr-Commit-Position: refs/heads/master@{#473574} Committed: https://chromium.googlesource.com/chromium/src/+/102feab6fd73e6b0510c572165d1... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as https://chromium.googlesource.com/chromium/src/+/102feab6fd73e6b0510c572165d1... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
