Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2893533002: Implement WorkerFetchContext::AddResourceTiming() for off-main-thread-fetch (Closed)

Created:
3 years, 7 months ago by horo
Modified:
3 years, 7 months ago
Reviewers:
falken, yhirano
CC:
chromium-reviews, blink-reviews, jshin+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement WorkerFetchContext::AddResourceTiming() for off-main-thread-fetch After this CL, performance.getEntries() will return the ResourceTiming information of the requests which are fetched from the worker even if off-main-thread-fetch is enabled (--enable-features=OffMainThreadFetch). BUG=443374 Review-Url: https://codereview.chromium.org/2893533002 Cr-Commit-Position: refs/heads/master@{#472652} Committed: https://chromium.googlesource.com/chromium/src/+/e6bdad2acc6f745d504782ca9e3655d2570393e7

Patch Set 1 #

Patch Set 2 : add performance-timeline.https-expected.txt #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -44 lines) Patch
A + third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/performance-timeline.https-expected.txt View 1 1 chunk +2 lines, -1 line 2 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-cache-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-content-encoding-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-cors-preflight-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-redirect-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-xhr-fetch-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/serviceworker/chromium.performance-timeline-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/workers/resource-timing-allow-origin-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/workers/shared-worker-performance-timeline-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/workers/worker-performance-timeline-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerFetchContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
horo
falken@
3 years, 7 months ago (2017-05-17 05:55:48 UTC) #8
horo
falken@ Please review this.
3 years, 7 months ago (2017-05-17 05:55:56 UTC) #9
falken
lgtm https://codereview.chromium.org/2893533002/diff/20001/third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/performance-timeline.https-expected.txt File third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/performance-timeline.https-expected.txt (right): https://codereview.chromium.org/2893533002/diff/20001/third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/performance-timeline.https-expected.txt#newcode6 third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/performance-timeline.https-expected.txt:6: Harness: the test ran to completion. Can the ...
3 years, 7 months ago (2017-05-18 01:17:25 UTC) #12
horo
https://codereview.chromium.org/2893533002/diff/20001/third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/performance-timeline.https-expected.txt File third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/performance-timeline.https-expected.txt (right): https://codereview.chromium.org/2893533002/diff/20001/third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/performance-timeline.https-expected.txt#newcode6 third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/performance-timeline.https-expected.txt:6: Harness: the test ran to completion. On 2017/05/18 01:17:24, ...
3 years, 7 months ago (2017-05-18 01:49:38 UTC) #13
horo
yhirano@ Could you please review third_party/WebKit/Source/core/loader/WorkerFetchContext.*?
3 years, 7 months ago (2017-05-18 01:50:24 UTC) #15
yhirano
lgtm
3 years, 7 months ago (2017-05-18 01:52:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893533002/20001
3 years, 7 months ago (2017-05-18 01:55:30 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 03:52:47 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e6bdad2acc6f745d504782ca9e36...

Powered by Google App Engine
This is Rietveld 408576698