third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/performance-timeline.https-expected.txt - Issue 2893533002: Implement WorkerFetchContext::AddResourceTiming() for off-main-thread-fetch

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/performance-timeline.https-expected.txt

Issue 2893533002: Implement WorkerFetchContext::AddResourceTiming() for off-main-thread-fetch (Closed)

Patch Set: add performance-timeline.https-expected.txt Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 This is a testharness.js-based test.	1 This is a testharness.js-based test.

2 PASS Test Performance Timeline API in Service Worker	2 PASS Test Performance Timeline API in Service Worker

	3 PASS empty service worker fetch event included in performance timings

3 PASS User Timing	4 PASS User Timing

4 FAIL Resource Timing assert_equals: expected 2 but got 1	5 PASS Resource Timing

5 Harness: the test ran to completion.	6 Harness: the test ran to completion.
	falken 2017/05/18 01:17:24 Can the expected.txt be removed, since all tests P Can the expected.txt be removed, since all tests PASS? horo 2017/05/18 01:49:38 The current implementation (without OffMainThreadF Show quoted text On 2017/05/18 01:17:24, falken wrote: > Can the expected.txt be removed, since all tests PASS? The current implementation (without OffMainThreadFetch) doesn't pass the test, because of thread hop ordering issue. https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/virtual/o... So we need this all passing -expected.txt file.
6	7

OLD	NEW