Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2893523003: [ObjC ARC] Converts ios/chrome/browser/omaha:omaha to ARC. (Closed)

Created:
3 years, 7 months ago by liaoyuke
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/omaha:omaha to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2893523003 Cr-Commit-Position: refs/heads/master@{#477742} Committed: https://chromium.googlesource.com/chromium/src/+/0527f72f6822c6aba0370d8245bd9acb6715a2f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M ios/chrome/browser/omaha/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/omaha/omaha_service.mm View 6 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
liaoyuke
Hi Rohit, PTAL. Thank you very much!
3 years, 6 months ago (2017-05-30 17:39:01 UTC) #6
rohitrao (ping after 24h)
+stk as the primary reviewer. @stk is there anyone else who would be a good ...
3 years, 6 months ago (2017-06-01 11:03:12 UTC) #8
stkhapugin
lgtm. I don't mind reviewing them all, please feel free to send me all your ...
3 years, 6 months ago (2017-06-01 11:50:44 UTC) #9
rohitrao (ping after 24h)
lgtm
3 years, 6 months ago (2017-06-01 17:29:41 UTC) #10
rohitrao (ping after 24h)
lgtm
3 years, 6 months ago (2017-06-05 14:37:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893523003/1
3 years, 6 months ago (2017-06-06 22:35:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/442613)
3 years, 6 months ago (2017-06-06 23:23:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893523003/1
3 years, 6 months ago (2017-06-07 19:17:00 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 20:09:03 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0527f72f6822c6aba0370d8245bd...

Powered by Google App Engine
This is Rietveld 408576698