DevTools: migrate ScopeChainSidebarPane to shadow

DevTools: migrate ScopeChainSidebarPane to shadow

BUG=726972
Review-Url: https://codereview.chromium.org/2893393002
Cr-Commit-Position: refs/heads/master@{#475238}
Committed: https://chromium.googlesource.com/chromium/src/+/da68948cb526ff7b5737fd334152aba758e913aa

[luoe, 2017-05-22 18:42:49]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org

[luoe, 2017-05-22 18:42:50]

Please take a look

This is part of an effort to move more things into components.

Some of the css rules are unused/need cleaning, but I'd like to do clean sources
styles together in a separate patch.

[luoe, 2017-05-24 23:35:25]

Description was changed from

==========
DevTools: migrate ScopeChainSidebarPane to shadow

BUG=none
==========

to

==========
DevTools: migrate ScopeChainSidebarPane to shadow

BUG=none
==========

[luoe, 2017-05-24 23:35:25]

luoe@chromium.org changed reviewers:
+ einbinder@chromium.org

[einbinder, 2017-05-25 00:13:00]

https://codereview.chromium.org/2893393002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/scopeChainSidebarPane.css
(right):

https://codereview.chromium.org/2893393002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/scopeChainSidebarPane.css:1:
.scope-chain-sidebar-pane-section-header {
Copyright

https://codereview.chromium.org/2893393002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css
(left):

https://codereview.chromium.org/2893393002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css:176:
.scope-chain-sidebar-pane-section-subtitle {
This code was pasted twice? That's silly.

[dgozman, 2017-05-25 00:18:56]

lgtm

[luoe, 2017-05-27 03:01:32]

Thanks for the reviews, you two!

https://codereview.chromium.org/2893393002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/scopeChainSidebarPane.css
(right):

https://codereview.chromium.org/2893393002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/scopeChainSidebarPane.css:1:
.scope-chain-sidebar-pane-section-header {
On 2017/05/25 00:12:59, einbinder wrote:
> Copyright

Thanks, nice catch.

https://codereview.chromium.org/2893393002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css
(left):

https://codereview.chromium.org/2893393002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css:176:
.scope-chain-sidebar-pane-section-subtitle {
On 2017/05/25 00:13:00, einbinder wrote:
> This code was pasted twice? That's silly.

Acknowledged.

[luoe, 2017-05-27 03:01:45]

The CQ bit was checked by luoe@chromium.org

[luoe, 2017-05-27 03:01:46]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2893393002/#ps20001
(title: "copyright")

[commit-bot: I haz the power, 2017-05-27 03:02:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[luoe, 2017-05-27 03:02:33]

Description was changed from

==========
DevTools: migrate ScopeChainSidebarPane to shadow

BUG=none
==========

to

==========
DevTools: migrate ScopeChainSidebarPane to shadow

BUG=726972
==========

[commit-bot: I haz the power, 2017-05-27 05:05:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495854105314580,
"parent_rev": "b109b249a23d3146575b12b1fa4781ade53dac28", "commit_rev":
"da68948cb526ff7b5737fd334152aba758e913aa"}

[commit-bot: I haz the power, 2017-05-27 05:05:12]

Description was changed from

==========
DevTools: migrate ScopeChainSidebarPane to shadow

BUG=726972
==========

to

==========
DevTools: migrate ScopeChainSidebarPane to shadow

BUG=726972

Review-Url: https://codereview.chromium.org/2893393002
Cr-Commit-Position: refs/heads/master@{#475238}
Committed:
https://chromium.googlesource.com/chromium/src/+/da68948cb526ff7b5737fd334152...
==========

[commit-bot: I haz the power, 2017-05-27 05:05:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/da68948cb526ff7b5737fd334152...