Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

Issue 2893393002: DevTools: migrate ScopeChainSidebarPane to shadow (Closed)
Patch Set: copyright Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
index fc641116b23d2e85ccb7e318ad4b1cf4f099fb06..575483c4774cd4e192b602cb17d5b9a93a0999b6 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
@@ -29,7 +29,8 @@
*/
Sources.ScopeChainSidebarPane = class extends UI.VBox {
constructor() {
- super();
+ super(true);
+ this.registerRequiredCSS('sources/scopeChainSidebarPane.css');
this._expandController = new ObjectUI.ObjectPropertiesSectionExpandController();
this._linkifier = new Components.Linkifier();
this._update();
@@ -56,13 +57,13 @@ Sources.ScopeChainSidebarPane = class extends UI.VBox {
* @param {?SDK.RemoteObject} thisObject
*/
_innerUpdate(details, callFrame, thisObject) {
- this.element.removeChildren();
+ this.contentElement.removeChildren();
if (!details || !callFrame) {
var infoElement = createElement('div');
infoElement.className = 'gray-info-message';
infoElement.textContent = Common.UIString('Not Paused');
- this.element.appendChild(infoElement);
+ this.contentElement.appendChild(infoElement);
return;
}
@@ -124,7 +125,7 @@ Sources.ScopeChainSidebarPane = class extends UI.VBox {
section.objectTreeElement().expand();
section.element.classList.add('scope-chain-sidebar-pane-section');
- this.element.appendChild(section.element);
+ this.contentElement.appendChild(section.element);
}
this._sidebarPaneUpdatedForTest();
}
« no previous file with comments | « third_party/WebKit/Source/devtools/BUILD.gn ('k') | third_party/WebKit/Source/devtools/front_end/sources/module.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698