Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2893303002: Use SetSelection in InputMethodController::SetSelectionOffsets (Closed)

Created:
3 years, 7 months ago by tanvir
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SetSelection in InputMethodController::SetSelectionOffsets InputMethodController::SetSelectionOffsets function is changed to use SetSelection instead of SetSelectedRange. BUG=721190 Review-Url: https://codereview.chromium.org/2893303002 Cr-Commit-Position: refs/heads/master@{#473793} Committed: https://chromium.googlesource.com/chromium/src/+/d8b32218f49b4a92fbf0e51f646bccd1d3d693a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
tanvir
PTAL!!! Thanks
3 years, 7 months ago (2017-05-22 14:11:19 UTC) #3
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-23 01:19:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893303002/1
3 years, 7 months ago (2017-05-23 01:19:39 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 02:58:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d8b32218f49b4a92fbf0e51f646b...

Powered by Google App Engine
This is Rietveld 408576698