Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 2893303002: Use SetSelection in InputMethodController::SetSelectionOffsets (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/InputMethodController.cpp
diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.cpp b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
index a599bc244cc220be9c5bee68ad776c046aa22b0d..1785291fa15cd4625a021d3547de6ecc27cbe756 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodController.cpp
+++ b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
@@ -803,9 +803,9 @@ bool InputMethodController::SetSelectionOffsets(
if (range.IsNull())
return false;
- return GetFrame().Selection().SetSelectedRange(
- range, VP_DEFAULT_AFFINITY, SelectionDirectionalMode::kNonDirectional,
- options);
+ GetFrame().Selection().SetSelection(
+ SelectionInDOMTree::Builder().SetBaseAndExtent(range).Build(), options);
+ return true;
}
bool InputMethodController::SetEditableSelectionOffsets(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698