Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2893253002: Revert of [csa] Add assertions to CSA (Closed)

Created:
3 years, 7 months ago by jgruber
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [csa] Add assertions to CSA (patchset #14 id:260001 of https://codereview.chromium.org/2847923003/ ) Reason for revert: Linux-nosnap failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/13282 Original issue's description: > [csa] Add assertions to CSA > > This adds a bunch of assertions to CSA, mostly about documenting and checking > parameter types. > > Drive-by-change: Removed unused function. > > BUG=v8:6325 > > Review-Url: https://codereview.chromium.org/2847923003 > Cr-Original-Commit-Position: refs/heads/master@{#45398} > Committed: https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d6b4bd > Review-Url: https://codereview.chromium.org/2847923003 > Cr-Commit-Position: refs/heads/master@{#45443} > Committed: https://chromium.googlesource.com/v8/v8/+/62b0de1ef53816d6dae3fa519a846f942b701dda TBR=cbruni@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6325 Review-Url: https://codereview.chromium.org/2893253002 Cr-Commit-Position: refs/heads/master@{#45445} Committed: https://chromium.googlesource.com/v8/v8/+/937694497649522e02b3f8baf96002e8368f08a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -182 lines) Patch
M src/code-stub-assembler.h View 6 chunks +18 lines, -17 lines 0 comments Download
M src/code-stub-assembler.cc View 62 chunks +30 lines, -161 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jgruber
Created Revert of [csa] Add assertions to CSA
3 years, 7 months ago (2017-05-22 09:07:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893253002/1
3 years, 7 months ago (2017-05-22 09:07:15 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 09:07:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/937694497649522e02b3f8baf96002e8368...

Powered by Google App Engine
This is Rietveld 408576698