[csa] Add assertions to CSA

[csa] Add assertions to CSA

This adds a bunch of assertions to CSA, mostly about documenting and checking
parameter types.

Drive-by-change: Removed unused function.

BUG=v8:6325
Review-Url: https://codereview.chromium.org/2847923003
Cr-Original-Original-Commit-Position: refs/heads/master@{#45398}
Committed: https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d6b4bd
Review-Url: https://codereview.chromium.org/2847923003
Cr-Original-Commit-Position: refs/heads/master@{#45443}
Committed: https://chromium.googlesource.com/v8/v8/+/62b0de1ef53816d6dae3fa519a846f942b701dda
Review-Url: https://codereview.chromium.org/2847923003
Cr-Commit-Position: refs/heads/master@{#45607}
Committed: https://chromium.googlesource.com/v8/v8/+/9ca164d05114008ba21e7e65da29271392c8efe9

[jgruber, 2017-04-28 11:57:15]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 11:57:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 12:00:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 12:00:08]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/25176)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)

[jgruber, 2017-04-28 13:10:17]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 13:10:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-28 13:14:21]

Description was changed from

==========
[csa] Add assertions to CSA

This adds a bunch of assertions, mostly about documenting and checking
parameter types, to CSA.

Drive-by-change: Removed unused function.

BUG=v8:6325
==========

to

==========
[csa] Add assertions to CSA

This adds a bunch of assertions to CSA, mostly about documenting and checking
parameter types.

Drive-by-change: Removed unused function.

BUG=v8:6325
==========

[jgruber, 2017-04-28 13:35:48]

jgruber@chromium.org changed reviewers:
+ cbruni@chromium.org, ishell@chromium.org

[jgruber, 2017-04-28 13:35:49]

Hey, ptal. The downside of these is that SLOW_ASSERT builds become noticeably
slower.

[commit-bot: I haz the power, 2017-04-28 14:59:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 14:59:08]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/25186)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[jgruber, 2017-04-28 15:02:18]

On 2017/04/28 13:35:49, jgruber wrote:
> Hey, ptal. The downside of these is that SLOW_ASSERT builds become noticeably
> slower.

And some tests are crashing on linux_dbg_ng, will check it out next week.

[Camillo Bruni, 2017-04-28 15:57:45]

Nice! LGMT + nits

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:1438: CSA_SLOW_ASSERT(this, IsFixedArray(context));
I've prepared an IsContext which will call HeapObject::IsContext. Will land in a
separate CL.

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:2224: CSA_SLOW_ASSERT(this, TaggedIsSmi(length));
TaggedIsPositiveSmi(length)

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:2242: CSA_SLOW_ASSERT(this, TaggedIsSmi(length));
TaggedIsPositiveSmi(length)

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:2270: CSA_SLOW_ASSERT(this, TaggedIsSmi(length));
TaggedIsPositiveSmi(length)

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:2295: CSA_SLOW_ASSERT(this, TaggedIsSmi(length));
TaggedIsPositiveSmi(length)

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler.h
File src/code-stub-assembler.h (right):

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.h:117: Node* IsParameterMode(Node* value, ParameterMode
mode);
A bit a confusing name, how about: IsParameterModeCompatible or
MatchesParameterMode?

[Camillo Bruni, 2017-04-28 15:58:00]

LGTM, gee so hard to type.

[jgruber, 2017-05-02 07:17:30]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 07:17:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 07:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 07:52:14]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/25263)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[jgruber, 2017-05-02 09:08:37]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 09:08:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 10:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 10:08:33]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/25280)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Igor Sheludko, 2017-05-02 10:37:17]

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:198: return (mode == SMI_PARAMETERS) ?
TaggedIsSmi(value) : Int32Constant(1);
Maybe CSA_ASSERT_PARAMETER_MODE(csa, value, mode) would be a better choice.

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:461: CSA_SLOW_ASSERT(this, TaggedIsSmi(b));
I'd rather put these asserts into SmiLessThan() (see SMI_COMPARISON_OP and
similarily into SMI_ARITHMETIC_BINOP and SmiSh[l/r]).

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:473: CSA_SLOW_ASSERT(this, TaggedIsSmi(b));
This is overkill, since SmiToWord32()s will do the same checks again.

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:539: CSA_SLOW_ASSERT(this, TaggedIsSmi(b));
Same here.

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:1145: // Cannot assert IsMap(map) here since that
would induce a cycle.
IsMap() should be implemented via comparing map of an object with meta map
constant. It will even require less instructions.

Please fix it while you are here.

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:1422: CSA_SLOW_ASSERT(this, IsFixedArray(context));
Maybe also add IsContext(). 

BTW, I saw a CL flying by where it was suggested to call HeapObject::IsContext()
from CSA. As an alternative we can use the power of macros to generate both C++
and CSA IsContext()s.

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:2141: CSA_SLOW_ASSERT(this,
IsFixedArray(dictionary));
CSA::IsDictionary(dictionary)

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:2278: CSA_ASSERT(this, TaggedIsSmi(length));
Already exists. "Only one can remain" (c).

[jgruber, 2017-05-03 11:10:22]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 11:10:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-03 11:11:51]

Thanks, addressed all comments. This flushed out a possible crankshaft bug which
means a couple of tests will still fail on the upcoming patchset. Will do a
final pass through failing tests and update test .status files before landing.

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:1438: CSA_SLOW_ASSERT(this, IsFixedArray(context));
On 2017/04/28 15:57:44, Camillo Bruni wrote:
> I've prepared an IsContext which will call HeapObject::IsContext. Will land in
a
> separate CL.

Acknowledged.

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:2224: CSA_SLOW_ASSERT(this, TaggedIsSmi(length));
On 2017/04/28 15:57:44, Camillo Bruni wrote:
> TaggedIsPositiveSmi(length)

Done.

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:2242: CSA_SLOW_ASSERT(this, TaggedIsSmi(length));
On 2017/04/28 15:57:44, Camillo Bruni wrote:
> TaggedIsPositiveSmi(length)

Done.

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:2270: CSA_SLOW_ASSERT(this, TaggedIsSmi(length));
On 2017/04/28 15:57:44, Camillo Bruni wrote:
> TaggedIsPositiveSmi(length)

Done.

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:2295: CSA_SLOW_ASSERT(this, TaggedIsSmi(length));
On 2017/04/28 15:57:44, Camillo Bruni wrote:
> TaggedIsPositiveSmi(length)

Done.

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler.h
File src/code-stub-assembler.h (right):

https://codereview.chromium.org/2847923003/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.h:117: Node* IsParameterMode(Node* value, ParameterMode
mode);
On 2017/04/28 15:57:44, Camillo Bruni wrote:
> A bit a confusing name, how about: IsParameterModeCompatible or
> MatchesParameterMode?

Agreed, changed to MatchesParameterMode.

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:198: return (mode == SMI_PARAMETERS) ?
TaggedIsSmi(value) : Int32Constant(1);
On 2017/05/02 10:37:16, Igor Sheludko wrote:
> Maybe CSA_ASSERT_PARAMETER_MODE(csa, value, mode) would be a better choice.

CSA_ASSERT_PARAMETER_MODE(csa, value, mode)
CSA_ASSERT(csa, IsParameterMode(value, mode))

No strong opinion either way, but I'm not sure it makes sense to introduce a new
macro for this assertion.

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:461: CSA_SLOW_ASSERT(this, TaggedIsSmi(b));
On 2017/05/02 10:37:17, Igor Sheludko wrote:
> I'd rather put these asserts into SmiLessThan() (see SMI_COMPARISON_OP and
> similarily into SMI_ARITHMETIC_BINOP and SmiSh[l/r]).

Done.

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:473: CSA_SLOW_ASSERT(this, TaggedIsSmi(b));
On 2017/05/02 10:37:17, Igor Sheludko wrote:
> This is overkill, since SmiToWord32()s will do the same checks again.

Done. Although I like having documentation of the expected node types next to
the function signature (types are pretty obvious in this case, but in others
they aren't). I've heard people talking about typed nodes (e.g. Node<Type>),
that would be pretty awesome.

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:539: CSA_SLOW_ASSERT(this, TaggedIsSmi(b));
On 2017/05/02 10:37:17, Igor Sheludko wrote:
> Same here.

Done.

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:1145: // Cannot assert IsMap(map) here since that
would induce a cycle.
On 2017/05/02 10:37:16, Igor Sheludko wrote:
> IsMap() should be implemented via comparing map of an object with meta map
> constant. It will even require less instructions.
> 
> Please fix it while you are here.

Done.

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:1422: CSA_SLOW_ASSERT(this, IsFixedArray(context));
On 2017/05/02 10:37:16, Igor Sheludko wrote:
> Maybe also add IsContext(). 
> 
> BTW, I saw a CL flying by where it was suggested to call
HeapObject::IsContext()
> from CSA. As an alternative we can use the power of macros to generate both
C++
> and CSA IsContext()s.

I suggest we wait for Camillo's IsContext to land and update these after.

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:2141: CSA_SLOW_ASSERT(this,
IsFixedArray(dictionary));
On 2017/05/02 10:37:17, Igor Sheludko wrote:
> CSA::IsDictionary(dictionary)

Done.

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:2278: CSA_ASSERT(this, TaggedIsSmi(length));
On 2017/05/02 10:37:17, Igor Sheludko wrote:
> Already exists. "Only one can remain" (c).

Done.

[jgruber, 2017-05-03 11:12:24]

FYI: Crankshaft bug at http://crbug.com/v8/6342

[Igor Sheludko, 2017-05-03 11:21:45]

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:198: return (mode == SMI_PARAMETERS) ?
TaggedIsSmi(value) : Int32Constant(1);
On 2017/05/03 11:11:51, jgruber wrote:
> On 2017/05/02 10:37:16, Igor Sheludko wrote:
> > Maybe CSA_ASSERT_PARAMETER_MODE(csa, value, mode) would be a better choice.
> 
> CSA_ASSERT_PARAMETER_MODE(csa, value, mode)
> CSA_ASSERT(csa, IsParameterMode(value, mode))
> 
> No strong opinion either way, but I'm not sure it makes sense to introduce a
new
> macro for this assertion.

Even better idea: ensure that CSA::Assert() is no-op when the condition !=
Int32Constant(0).

[commit-bot: I haz the power, 2017-05-03 12:12:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 12:12:17]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/25371)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[jgruber, 2017-05-03 12:32:54]

On 2017/05/03 11:21:45, Igor Sheludko wrote:
>
https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler.cc
> File src/code-stub-assembler.cc (right):
> 
>
https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
> src/code-stub-assembler.cc:198: return (mode == SMI_PARAMETERS) ?
> TaggedIsSmi(value) : Int32Constant(1);
> On 2017/05/03 11:11:51, jgruber wrote:
> > On 2017/05/02 10:37:16, Igor Sheludko wrote:
> > > Maybe CSA_ASSERT_PARAMETER_MODE(csa, value, mode) would be a better
choice.
> > 
> > CSA_ASSERT_PARAMETER_MODE(csa, value, mode)
> > CSA_ASSERT(csa, IsParameterMode(value, mode))
> > 
> > No strong opinion either way, but I'm not sure it makes sense to introduce a
> new
> > macro for this assertion.
> 
> Even better idea: ensure that CSA::Assert() is no-op when the condition !=
> Int32Constant(0).

SGTM, will do in a follow-up.

I've also been thinking of removing the csa argument from CSA_ASSERT, 99% of the
time it's just 'this'.

[Igor Sheludko, 2017-05-03 14:02:43]

On 2017/05/03 12:32:54, jgruber wrote:
> On 2017/05/03 11:21:45, Igor Sheludko wrote:
> >
>
https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler.cc
> > File src/code-stub-assembler.cc (right):
> > 
> >
>
https://codereview.chromium.org/2847923003/diff/60001/src/code-stub-assembler...
> > src/code-stub-assembler.cc:198: return (mode == SMI_PARAMETERS) ?
> > TaggedIsSmi(value) : Int32Constant(1);
> > On 2017/05/03 11:11:51, jgruber wrote:
> > > On 2017/05/02 10:37:16, Igor Sheludko wrote:
> > > > Maybe CSA_ASSERT_PARAMETER_MODE(csa, value, mode) would be a better
> choice.
> > > 
> > > CSA_ASSERT_PARAMETER_MODE(csa, value, mode)
> > > CSA_ASSERT(csa, IsParameterMode(value, mode))
> > > 
> > > No strong opinion either way, but I'm not sure it makes sense to introduce
a
> > new
> > > macro for this assertion.
> > 
> > Even better idea: ensure that CSA::Assert() is no-op when the condition !=
> > Int32Constant(0).
> 
> SGTM, will do in a follow-up.
> 
> I've also been thinking of removing the csa argument from CSA_ASSERT, 99% of
the
> time it's just 'this'.

sgtm+lgtm

[Igor Sheludko, 2017-05-03 14:03:05]

sgtm+lgtm

https://codereview.chromium.org/2847923003/diff/80001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2847923003/diff/80001/src/code-stub-assembler...
src/code-stub-assembler.cc:3289: return WordEqual(LoadMap(map),
MetaMapConstant());
return IsMetaMap(LoadMap(map));

[jgruber, 2017-05-08 12:44:05]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 12:44:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 13:39:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 13:39:32]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/25593)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[jgruber, 2017-05-09 11:45:54]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 11:46:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 11:47:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 11:47:32]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/25653)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/40703)

[jgruber, 2017-05-09 11:52:04]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 11:52:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 12:47:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 12:47:25]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/25654)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[jgruber, 2017-05-11 09:14:10]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 09:14:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 10:26:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 10:26:10]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/25776)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[jgruber, 2017-05-11 12:58:44]

Created http://crbug.com/v8/6390 for the register allocation failure. I'll leave
this on hold until that is resolved.

[jgruber, 2017-05-18 11:27:55]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 11:28:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 12:40:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 12:40:30]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/26127)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[jgruber, 2017-05-18 13:34:30]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 13:34:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 14:07:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 14:07:05]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-05-18 14:33:36]

Woohoo, finally passes all tests. Please take another quick pass.

https://codereview.chromium.org/2847923003/diff/80001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2847923003/diff/80001/src/code-stub-assembler...
src/code-stub-assembler.cc:3289: return WordEqual(LoadMap(map),
MetaMapConstant());
On 2017/05/03 14:03:05, Igor Sheludko wrote:
> return IsMetaMap(LoadMap(map));

Done.

[Igor Sheludko, 2017-05-18 15:06:31]

lgtm

[jgruber, 2017-05-18 15:44:53]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-05-18 15:44:54]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2847923003/#ps200001
(title: "Internalize strings produced for CSA_ASSERT")

[commit-bot: I haz the power, 2017-05-18 15:45:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 15:46:41]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1495122293808320,
"parent_rev": "0c0ab3dce09bd0367e834170c135a12772d5e9a6", "commit_rev":
"b14a981496ad1f841683479d2f9188dfa2d6b4bd"}

[commit-bot: I haz the power, 2017-05-18 15:46:49]

Description was changed from

==========
[csa] Add assertions to CSA

This adds a bunch of assertions to CSA, mostly about documenting and checking
parameter types.

Drive-by-change: Removed unused function.

BUG=v8:6325
==========

to

==========
[csa] Add assertions to CSA

This adds a bunch of assertions to CSA, mostly about documenting and checking
parameter types.

Drive-by-change: Removed unused function.

BUG=v8:6325

Review-Url: https://codereview.chromium.org/2847923003
Cr-Commit-Position: refs/heads/master@{#45398}
Committed:
https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d...
==========

[commit-bot: I haz the power, 2017-05-18 15:46:50]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d...

[Michael Achenbach, 2017-05-18 18:43:57]

A revert of this CL (patchset #11 id:200001) has been created in
https://codereview.chromium.org/2892023002/ by machenbach@chromium.org.

The reason for reverting is: Seems to have made nosnap debug very slow and also
leads to check failures:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2....

[jgruber, 2017-05-19 08:38:19]

Description was changed from

==========
[csa] Add assertions to CSA

This adds a bunch of assertions to CSA, mostly about documenting and checking
parameter types.

Drive-by-change: Removed unused function.

BUG=v8:6325

Review-Url: https://codereview.chromium.org/2847923003
Cr-Commit-Position: refs/heads/master@{#45398}
Committed:
https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d...
==========

to

==========
[csa] Add assertions to CSA

This adds a bunch of assertions to CSA, mostly about documenting and checking
parameter types.

Drive-by-change: Removed unused function.

BUG=v8:6325

Review-Url: https://codereview.chromium.org/2847923003
Cr-Commit-Position: refs/heads/master@{#45398}
Committed:
https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d...
==========

[jgruber, 2017-05-19 08:38:39]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 08:38:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-19 08:43:13]

On 2017/05/18 18:43:57, Michael Achenbach wrote:
> A revert of this CL (patchset #11 id:200001) has been created in
> https://codereview.chromium.org/2892023002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: Seems to have made nosnap debug very slow and
also
> leads to check failures:
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2....

The latest patchset removes low-level asserts (e.g. in SmiAdd & co) to avoid
excessive slowdown on bots.

[commit-bot: I haz the power, 2017-05-19 09:07:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 09:07:42]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-05-22 06:53:58]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-05-22 06:53:58]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2847923003/#ps220001
(title: "Remove most low-level asserts")

[commit-bot: I haz the power, 2017-05-22 06:54:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 06:55:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 06:55:40]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/26194)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/41535)

[jgruber, 2017-05-22 07:25:09]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 07:25:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-22 07:29:29]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 07:29:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 07:58:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 07:58:19]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-05-22 08:05:12]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-05-22 08:05:13]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2847923003/#ps260001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-22 08:05:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 08:06:59]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1495440312575650,
"parent_rev": "897c2ca3311f937df40c45d0dced259b53404584", "commit_rev":
"62b0de1ef53816d6dae3fa519a846f942b701dda"}

[commit-bot: I haz the power, 2017-05-22 08:07:07]

Description was changed from

==========
[csa] Add assertions to CSA

This adds a bunch of assertions to CSA, mostly about documenting and checking
parameter types.

Drive-by-change: Removed unused function.

BUG=v8:6325

Review-Url: https://codereview.chromium.org/2847923003
Cr-Commit-Position: refs/heads/master@{#45398}
Committed:
https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d...
==========

to

==========
[csa] Add assertions to CSA

This adds a bunch of assertions to CSA, mostly about documenting and checking
parameter types.

Drive-by-change: Removed unused function.

BUG=v8:6325

Review-Url: https://codereview.chromium.org/2847923003
Cr-Original-Commit-Position: refs/heads/master@{#45398}
Committed:
https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d...
Review-Url: https://codereview.chromium.org/2847923003
Cr-Commit-Position: refs/heads/master@{#45443}
Committed:
https://chromium.googlesource.com/v8/v8/+/62b0de1ef53816d6dae3fa519a846f942b7...
==========

[commit-bot: I haz the power, 2017-05-22 08:07:08]

Committed patchset #14 (id:260001) as
https://chromium.googlesource.com/v8/v8/+/62b0de1ef53816d6dae3fa519a846f942b7...

[jgruber, 2017-05-22 09:07:06]

A revert of this CL (patchset #14 id:260001) has been created in
https://codereview.chromium.org/2893253002/ by jgruber@chromium.org.

The reason for reverting is: Linux-nosnap failures:

https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2....

[jgruber, 2017-05-22 10:44:30]

Description was changed from

==========
[csa] Add assertions to CSA

This adds a bunch of assertions to CSA, mostly about documenting and checking
parameter types.

Drive-by-change: Removed unused function.

BUG=v8:6325

Review-Url: https://codereview.chromium.org/2847923003
Cr-Original-Commit-Position: refs/heads/master@{#45398}
Committed:
https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d...
Review-Url: https://codereview.chromium.org/2847923003
Cr-Commit-Position: refs/heads/master@{#45443}
Committed:
https://chromium.googlesource.com/v8/v8/+/62b0de1ef53816d6dae3fa519a846f942b7...
==========

to

==========
[csa] Add assertions to CSA

This adds a bunch of assertions to CSA, mostly about documenting and checking
parameter types.

Drive-by-change: Removed unused function.

BUG=v8:6325

Review-Url: https://codereview.chromium.org/2847923003
Cr-Original-Commit-Position: refs/heads/master@{#45398}
Committed:
https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d...
Review-Url: https://codereview.chromium.org/2847923003
Cr-Commit-Position: refs/heads/master@{#45443}
Committed:
https://chromium.googlesource.com/v8/v8/+/62b0de1ef53816d6dae3fa519a846f942b7...
==========

[jgruber, 2017-05-30 13:48:11]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 13:48:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 14:17:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 14:17:54]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-05-30 14:18:52]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-05-30 14:18:53]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2847923003/#ps280001
(title: "Rebase & fix incorrect asserts")

[commit-bot: I haz the power, 2017-05-30 14:19:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 14:23:19]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1496153932911130,
"parent_rev": "a73323d3676ffc2263da40aff3e035a9c8c8c1f2", "commit_rev":
"9ca164d05114008ba21e7e65da29271392c8efe9"}

[commit-bot: I haz the power, 2017-05-30 14:23:28]

Description was changed from

==========
[csa] Add assertions to CSA

This adds a bunch of assertions to CSA, mostly about documenting and checking
parameter types.

Drive-by-change: Removed unused function.

BUG=v8:6325

Review-Url: https://codereview.chromium.org/2847923003
Cr-Original-Commit-Position: refs/heads/master@{#45398}
Committed:
https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d...
Review-Url: https://codereview.chromium.org/2847923003
Cr-Commit-Position: refs/heads/master@{#45443}
Committed:
https://chromium.googlesource.com/v8/v8/+/62b0de1ef53816d6dae3fa519a846f942b7...
==========

to

==========
[csa] Add assertions to CSA

This adds a bunch of assertions to CSA, mostly about documenting and checking
parameter types.

Drive-by-change: Removed unused function.

BUG=v8:6325

Review-Url: https://codereview.chromium.org/2847923003
Cr-Original-Original-Commit-Position: refs/heads/master@{#45398}
Committed:
https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d...
Review-Url: https://codereview.chromium.org/2847923003
Cr-Original-Commit-Position: refs/heads/master@{#45443}
Committed:
https://chromium.googlesource.com/v8/v8/+/62b0de1ef53816d6dae3fa519a846f942b7...
Review-Url: https://codereview.chromium.org/2847923003
Cr-Commit-Position: refs/heads/master@{#45607}
Committed:
https://chromium.googlesource.com/v8/v8/+/9ca164d05114008ba21e7e65da29271392c...
==========

[commit-bot: I haz the power, 2017-05-30 14:23:29]

Committed patchset #15 (id:280001) as
https://chromium.googlesource.com/v8/v8/+/9ca164d05114008ba21e7e65da29271392c...