[Payment Request] Region data loader

[Payment Request] Region data loader

RegionDataLoader encapsulates the autofill::RegionComboboxModel details
and returns an array of region names asynchronously given a country code 
and an instance of autofill::RegionDataLoader. 

BUG=602666
Review-Url: https://codereview.chromium.org/2893193002
Cr-Commit-Position: refs/heads/master@{#473613}
Committed: https://chromium.googlesource.com/chromium/src/+/d9433138750c99a9c0a0698c2cb8ae1098cfbb31

[Moe, 2017-05-21 21:41:48]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-21 21:41:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2017-05-21 21:42:28]

mahmadi@chromium.org changed reviewers:
+ rouslan@chromium.org

[Moe, 2017-05-21 21:42:28]

Hi Rouslan, Please take a look.

[commit-bot: I haz the power, 2017-05-21 23:09:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 23:09:06]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-05-22 14:04:20]

Please expand the CL description to explain the need for this patch:

 - What happens before this patch.
 - How is this bad.
 - What does this patch do.
 - How does this patch fix that bad thing.

https://codereview.chromium.org/2893193002/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/region_data_loader.h (right):

https://codereview.chromium.org/2893193002/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/region_data_loader.h:32:
RegionDataLoader(id<RegionDataLoaderConsumer> consumer);
explicit

https://codereview.chromium.org/2893193002/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/region_data_loader.h:43:
std::unique_ptr<autofill::RegionComboboxModel> region_model_;
It appears that you instantiate region_model_ in the constructor and never reset
it. In this case, the best way to keep this variable around is as a member
variable with std::unique<>:

  autofill::RegionComboboxModel region_model_;

You will need to #include the header where this class is declared.

https://codereview.chromium.org/2893193002/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/region_data_loader_unittest.mm (right):

https://codereview.chromium.org/2893193002/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/region_data_loader_unittest.mm:30:
PaymentRequestRegionDataLoaderTest() {}
~PaymentRequestRegionDataLoaderTest() override {}

[Moe, 2017-05-22 15:53:49]

Description was changed from

==========
[Payment Request] Region data loader

BUG=602666
==========

to

==========
[Payment Request] Region data loader

RegionDataLoader encapsulates the autofill::RegionComboboxModel details
and returns an array of region names asynchronously given a country code 
and an instance of autofill::RegionDataLoader. 

BUG=602666
==========

[Moe, 2017-05-22 15:57:54]

Rouslan, PTAL.

https://codereview.chromium.org/2893193002/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/region_data_loader.h (right):

https://codereview.chromium.org/2893193002/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/region_data_loader.h:32:
RegionDataLoader(id<RegionDataLoaderConsumer> consumer);
On 2017/05/22 14:04:20, ಠ_ಠ wrote:
> explicit

Done.

https://codereview.chromium.org/2893193002/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/region_data_loader.h:43:
std::unique_ptr<autofill::RegionComboboxModel> region_model_;
On 2017/05/22 14:04:19, ಠ_ಠ wrote:
> It appears that you instantiate region_model_ in the constructor and never
reset
> it. In this case, the best way to keep this variable around is as a member
> variable with std::unique<>:
> 
>   autofill::RegionComboboxModel region_model_;
> 
> You will need to #include the header where this class is declared.

Done.

https://codereview.chromium.org/2893193002/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/region_data_loader_unittest.mm (right):

https://codereview.chromium.org/2893193002/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/region_data_loader_unittest.mm:30:
PaymentRequestRegionDataLoaderTest() {}
On 2017/05/22 14:04:20, ಠ_ಠ wrote:
> ~PaymentRequestRegionDataLoaderTest() override {}

Done.

[please use gerrit instead, 2017-05-22 16:01:02]

lgtm % comment

https://codereview.chromium.org/2893193002/diff/20001/ios/chrome/browser/ui/p...
File ios/chrome/browser/ui/payments/region_data_loader.h (right):

https://codereview.chromium.org/2893193002/diff/20001/ios/chrome/browser/ui/p...
ios/chrome/browser/ui/payments/region_data_loader.h:15: class
RegionComboboxModel;
No longer need to forward declare this class.

[Moe, 2017-05-22 16:23:44]

Thank you.

https://codereview.chromium.org/2893193002/diff/20001/ios/chrome/browser/ui/p...
File ios/chrome/browser/ui/payments/region_data_loader.h (right):

https://codereview.chromium.org/2893193002/diff/20001/ios/chrome/browser/ui/p...
ios/chrome/browser/ui/payments/region_data_loader.h:15: class
RegionComboboxModel;
On 2017/05/22 16:01:02, ಠ_ಠ wrote:
> No longer need to forward declare this class.

Done.

[Moe, 2017-05-22 16:23:49]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-05-22 16:23:50]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2893193002/#ps40001
(title: "Addressed comment")

[commit-bot: I haz the power, 2017-05-22 16:24:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 17:37:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495470229659650,
"parent_rev": "29a6403a0f484e7e33b63df2d738f0568559e180", "commit_rev":
"d9433138750c99a9c0a0698c2cb8ae1098cfbb31"}

[commit-bot: I haz the power, 2017-05-22 17:38:05]

Description was changed from

==========
[Payment Request] Region data loader

RegionDataLoader encapsulates the autofill::RegionComboboxModel details
and returns an array of region names asynchronously given a country code 
and an instance of autofill::RegionDataLoader. 

BUG=602666
==========

to

==========
[Payment Request] Region data loader

RegionDataLoader encapsulates the autofill::RegionComboboxModel details
and returns an array of region names asynchronously given a country code 
and an instance of autofill::RegionDataLoader. 

BUG=602666

Review-Url: https://codereview.chromium.org/2893193002
Cr-Commit-Position: refs/heads/master@{#473613}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9433138750c99a9c0a0698c2cb8...
==========

[commit-bot: I haz the power, 2017-05-22 17:38:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d9433138750c99a9c0a0698c2cb8...