Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2893353002: [Payment Request] Address edit view controller (Part 2) (Closed)

Created:
3 years, 7 months ago by Moe
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, mahmadi+paymentsioswatch_chromium.org, pkl (ping after 24h if needed), gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, mathp+autofillwatch_chromium.org, mahmadi+paymentswatch_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, sebsg+autofillwatch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Address edit view controller (Part 2) - Adds support for textfields with UIPickerView to edit view controller. - Mediator dynamically creates editor fields based on selected country. - Mediator loads regions asynchronously and notifies view controller. - Hooks up address edit coordinator with country selection coordinator. note: There is still no validation and saving the form results in DCHECK http://imgur.com/a/P52tS BUG=602666 Review-Url: https://codereview.chromium.org/2893353002 Cr-Commit-Position: refs/heads/master@{#473923} Committed: https://chromium.googlesource.com/chromium/src/+/83bd4fc4a3867df2afb401a4fcd8096dfc210a2e

Patch Set 1 : Initial #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -35 lines) Patch
M ios/chrome/browser/payments/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/payments/payment_request.h View 1 chunk +1 line, -1 line 0 comments Download
A ios/chrome/browser/payments/test_payment_request.h View 1 chunk +44 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/test_payment_request.mm View 1 chunk +17 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_ui_type.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm View 2 chunks +12 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/autofill/cells/autofill_edit_item.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/autofill/cells/autofill_edit_item.mm View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/payments/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/payments/address_edit_coordinator.h View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/address_edit_coordinator.mm View 6 chunks +27 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm View 2 chunks +17 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/payments/address_edit_mediator.h View 2 chunks +12 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/address_edit_mediator.mm View 5 chunks +208 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_edit_consumer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm View 10 chunks +117 lines, -25 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_editor_field.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_editor_field.mm View 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (17 generated)
Moe
Hi Louis, welcome back! Please take a look.
3 years, 7 months ago (2017-05-22 17:44:40 UTC) #8
lpromero
lgtm
3 years, 7 months ago (2017-05-23 08:26:26 UTC) #11
Moe
On 2017/05/23 08:26:26, lpromero wrote: > lgtm merci!
3 years, 7 months ago (2017-05-23 13:22:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893353002/20001
3 years, 7 months ago (2017-05-23 13:22:50 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/444763)
3 years, 7 months ago (2017-05-23 13:30:07 UTC) #18
Moe
Hi Justin, Could you please take a look at ios/c/b/u/autofill?
3 years, 7 months ago (2017-05-23 15:48:39 UTC) #20
Justin Donnelly
ios/c/b/u/autofill lgtm
3 years, 7 months ago (2017-05-23 15:58:56 UTC) #21
Moe
On 2017/05/23 15:58:56, Justin Donnelly wrote: > ios/c/b/u/autofill lgtm Thanks.
3 years, 7 months ago (2017-05-23 16:00:48 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893353002/20001
3 years, 7 months ago (2017-05-23 16:02:23 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 16:09:03 UTC) #27
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/83bd4fc4a3867df2afb401a4fcd8...

Powered by Google App Engine
This is Rietveld 408576698