Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2893093002: Revert of Add a mock vision-common GMS client target (Closed)

Created:
3 years, 7 months ago by paulmiller
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a mock vision-common GMS client target (patchset #1 id:1 of https://codereview.chromium.org/2888283002/ ) Reason for revert: broke downstream Original issue's description: > Add a mock vision-common GMS client target > > Upcoming GMS versions will split the vision client into vision and > vision-common. In order to roll downstream, we must add an upstream > dependency on vision-common. But upstream is not yet ready to roll, so > we add a mock vision-common target to temporarily satisfy the new > dependency in upstream builds. > > BUG=706943 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2888283002 > Cr-Commit-Position: refs/heads/master@{#473268} > Committed: https://chromium.googlesource.com/chromium/src/+/420cf37ad0ddf1c54203a4fdffb68af920503b0e TBR=agrieve@chromium.org,reillyg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=706943 Review-Url: https://codereview.chromium.org/2893093002 Cr-Commit-Position: refs/heads/master@{#473302} Committed: https://chromium.googlesource.com/chromium/src/+/9010e14d8fc816219fe22ca57b63a9d1eefef45b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M services/shape_detection/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
paulmiller
Created Revert of Add a mock vision-common GMS client target
3 years, 7 months ago (2017-05-19 20:38:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893093002/1
3 years, 7 months ago (2017-05-19 20:39:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9010e14d8fc816219fe22ca57b63a9d1eefef45b
3 years, 7 months ago (2017-05-19 20:39:56 UTC) #6
paulmiller
3 years, 7 months ago (2017-05-19 22:54:32 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2892953003/ by paulmiller@chromium.org.

The reason for reverting is: downstream breakage fixed by adding another mock
target downstream.

Powered by Google App Engine
This is Rietveld 408576698