Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2888283002:
Add a mock vision-common GMS client target (Closed)
|
Created:
3 years, 7 months ago by paulmiller Modified:
3 years, 7 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a mock vision-common GMS client target
Upcoming GMS versions will split the vision client into vision and
vision-common. In order to roll downstream, we must add an upstream
dependency on vision-common. But upstream is not yet ready to roll, so
we add a mock vision-common target to temporarily satisfy the new
dependency in upstream builds.
BUG=706943
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2888283002
Cr-Commit-Position: refs/heads/master@{#473268}
Committed: https://chromium.googlesource.com/chromium/src/+/420cf37ad0ddf1c54203a4fdffb68af920503b0e
Patch Set 1 #
Total comments: 2
Messages
Total messages: 17 (10 generated)
Description was changed from ========== Add a mock vision-common GMS client target Upcoming GMS versions will split the vision client into vision and vision-common. In order to roll downstream, we must add an upstream dependency on vision-common. But upstream is not yet ready to roll, so we add a mock vision-common target to temporarily satisfy the new dependency in upstream builds. BUG=706943 ========== to ========== Add a mock vision-common GMS client target Upcoming GMS versions will split the vision client into vision and vision-common. In order to roll downstream, we must add an upstream dependency on vision-common. But upstream is not yet ready to roll, so we add a mock vision-common target to temporarily satisfy the new dependency in upstream builds. BUG=706943 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Description was changed from ========== Add a mock vision-common GMS client target Upcoming GMS versions will split the vision client into vision and vision-common. In order to roll downstream, we must add an upstream dependency on vision-common. But upstream is not yet ready to roll, so we add a mock vision-common target to temporarily satisfy the new dependency in upstream builds. BUG=706943 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Add a mock vision-common GMS client target Upcoming GMS versions will split the vision client into vision and vision-common. In order to roll downstream, we must add an upstream dependency on vision-common. But upstream is not yet ready to roll, so we add a mock vision-common target to temporarily satisfy the new dependency in upstream builds. BUG=706943 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
paulmiller@chromium.org changed reviewers: + agrieve@chromium.org, reillyg@chromium.org
On 2017/05/18 01:50:32, paulmiller wrote: > mailto:paulmiller@chromium.org changed reviewers: > + mailto:agrieve@chromium.org, mailto:reillyg@chromium.org PTAL, agrieve@ for build/ and reillyg@ for services/shape_detection/.
The CQ bit was checked by paulmiller@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2888283002/diff/1/services/shape_detection/BU... File services/shape_detection/BUILD.gn (right): https://codereview.chromium.org/2888283002/diff/1/services/shape_detection/BU... services/shape_detection/BUILD.gn:79: "$google_play_services_package:google_play_services_vision_java", I assume we will need to depend on both of these targets? I can't find any documentation for "vision-common".
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
https://codereview.chromium.org/2888283002/diff/1/services/shape_detection/BU... File services/shape_detection/BUILD.gn (right): https://codereview.chromium.org/2888283002/diff/1/services/shape_detection/BU... services/shape_detection/BUILD.gn:79: "$google_play_services_package:google_play_services_vision_java", On 2017/05/18 04:55:22, Reilly Grant wrote: > I assume we will need to depend on both of these targets? I can't find any > documentation for "vision-common". Yep. Specifically, com.google.android.gms.vision.Frame is being moved from vision to vision-common in the next update.
On 2017/05/18 18:46:36, paulmiller wrote: > https://codereview.chromium.org/2888283002/diff/1/services/shape_detection/BU... > File services/shape_detection/BUILD.gn (right): > > https://codereview.chromium.org/2888283002/diff/1/services/shape_detection/BU... > services/shape_detection/BUILD.gn:79: > "$google_play_services_package:google_play_services_vision_java", > On 2017/05/18 04:55:22, Reilly Grant wrote: > > I assume we will need to depend on both of these targets? I can't find any > > documentation for "vision-common". > > Yep. Specifically, com.google.android.gms.vision.Frame is being moved from > vision to vision-common in the next update. lgtm. As an alternative, we could change vision_java to be a group that depends on the real vision_java as well as vision_common. Really that depends on whether it would ever be useful to depend on one without the other.
The CQ bit was checked by paulmiller@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495213725978240, "parent_rev":
"ef63607ebb648e211860b3b4604723d4adaac6b1", "commit_rev":
"420cf37ad0ddf1c54203a4fdffb68af920503b0e"}
Message was sent while issue was closed.
Description was changed from ========== Add a mock vision-common GMS client target Upcoming GMS versions will split the vision client into vision and vision-common. In order to roll downstream, we must add an upstream dependency on vision-common. But upstream is not yet ready to roll, so we add a mock vision-common target to temporarily satisfy the new dependency in upstream builds. BUG=706943 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Add a mock vision-common GMS client target Upcoming GMS versions will split the vision client into vision and vision-common. In order to roll downstream, we must add an upstream dependency on vision-common. But upstream is not yet ready to roll, so we add a mock vision-common target to temporarily satisfy the new dependency in upstream builds. BUG=706943 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2888283002 Cr-Commit-Position: refs/heads/master@{#473268} Committed: https://chromium.googlesource.com/chromium/src/+/420cf37ad0ddf1c54203a4fdffb6... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/420cf37ad0ddf1c54203a4fdffb6...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2893093002/ by paulmiller@chromium.org. The reason for reverting is: broke downstream. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
