third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp - Issue 2893083002: cc: Move SkShader construction to a single spot in PaintShader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

Issue 2893083002: cc: Move SkShader construction to a single spot in PaintShader (Closed)

Patch Set: update Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/tabs/tab.cc ('K') | « third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp ('k') | third_party/WebKit/Source/platform/graphics/Gradient.h » ('j') | ui/gfx/skia_paint_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

index beca1879493c666097627ea7996cd6878f39924c..c62926b2e872a77dfbb886abdf3495bf2b25849d 100644

--- a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

@@ -1831,9 +1831,8 @@ void BaseRenderingContext2D::CheckOverdraw(

if (is_source_over &&

image_type == CanvasRenderingContext2DState::kNoImage) {

- PaintShader* shader = flags->getShader();

- if (shader) {

- if (shader->isOpaque() && alpha == 0xFF)

+ if (flags->HasShader()) {

+ if (flags->ShaderIsOpaque() && alpha == 0xFF)

GetImageBuffer()->WillOverwriteCanvas();

return;

}