Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3556)

Unified Diff: chrome/browser/ui/views/tabs/tab.cc

Issue 2893083002: cc: Move SkShader construction to a single spot in PaintShader (Closed)
Patch Set: update Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/tab.cc
diff --git a/chrome/browser/ui/views/tabs/tab.cc b/chrome/browser/ui/views/tabs/tab.cc
index 38aeef5886207f778020af0e68db30f54fcf76fd..c51865edfd63fdb43c57badad5ab818599670bed 100644
--- a/chrome/browser/ui/views/tabs/tab.cc
+++ b/chrome/browser/ui/views/tabs/tab.cc
@@ -118,8 +118,8 @@ void DrawHighlight(gfx::Canvas* canvas,
const SkColor colors[2] = { color, SkColorSetA(color, 0) };
cc::PaintFlags flags;
flags.setAntiAlias(true);
- flags.setShader(cc::WrapSkShader(SkGradientShader::MakeRadial(
- p, radius, colors, nullptr, 2, SkShader::kClamp_TileMode)));
+ flags.setShader(base::MakeUnique<cc::PaintShader>(
sky 2017/06/02 22:51:05 include base/memory/ptr_util.h?
vmpstr 2017/06/05 21:02:07 Not needed after changes piman@ requested.
+ p, radius, colors, nullptr, 2, SkShader::kClamp_TileMode));
canvas->sk_canvas()->drawRect(
SkRect::MakeXYWH(p.x() - radius, p.y() - radius, radius * 2, radius * 2),
flags);

Powered by Google App Engine
This is Rietveld 408576698