Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js

Issue 2893073002: DevTools: introduce ResourceMapping (Closed)
Patch Set: cleanup test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
index b0006e5bdce566a52200cbc14ef2e847d5a60c63..70e0098e4f86e0160e613d2f7e42200606394b26 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
@@ -5,6 +5,7 @@ InspectorTest.createWorkspace = function()
InspectorTest.testTargetManager = new SDK.TargetManager();
InspectorTest.testWorkspace = new Workspace.Workspace();
InspectorTest.testNetworkProjectManager = new Bindings.NetworkProjectManager(InspectorTest.testTargetManager, InspectorTest.testWorkspace);
+ InspectorTest.testResourceBindingManager = new Bindings.ResourceBindingManager(InspectorTest.testTargetManager, InspectorTest.testWorkspace);
InspectorTest.testDebuggerWorkspaceBinding = new Bindings.DebuggerWorkspaceBinding(InspectorTest.testTargetManager, InspectorTest.testWorkspace);
}
@@ -13,6 +14,7 @@ InspectorTest.createMockTarget = function(id)
var capabilities = SDK.Target.Capability.AllForTests;
var target = InspectorTest.testTargetManager.createTarget("mock-target-id-" + id, "mock-target-" + id, capabilities & (~SDK.Target.Capability.JS), (params) => new SDK.StubConnection(params), null);
InspectorTest.testNetworkProject = Bindings.NetworkProject.forTarget(target);
+ InspectorTest.testResourceBinding = Bindings.ResourceBinding.forTarget(target);
target._capabilitiesMask = capabilities;
target._inspectedURL = InspectorTest.mainTarget.inspectedURL();
target.resourceTreeModel = target.model(SDK.ResourceTreeModel);
@@ -242,15 +244,15 @@ InspectorTest.addUISourceCode = function(target, breakpointManager, url, doNotSe
InspectorTest.addResult(" Adding UISourceCode: " + url);
// Add resource to get UISourceCode.
- var uiSourceCode = InspectorTest.testWorkspace.uiSourceCodeForURL(url);
- if (uiSourceCode)
- uiSourceCode.project().removeFile(url);
+ var resourceBinding = Bindings.ResourceBinding.forTarget(target);
+ if (resourceBinding._resourceFiles.has(url)) {
+ resourceBinding._resourceFiles.get(url).dispose();
+ resourceBinding._resourceFiles.delete(url);
+ }
var resource = new SDK.Resource(target, null, url, url, '', '', Common.resourceTypes.Document, 'text/html', null, null);
- InspectorTest.testNetworkProject._addResource(resource);
+ resourceBinding._resourceAdded({data: resource});
uiSourceCode = InspectorTest.testWorkspace.uiSourceCodeForURL(url);
- //var contentProvider = Common.StaticContentProvider.fromString(url, Common.resourceTypes.Script, "");
- //var uiSourceCode = InspectorTest.testNetworkProject.addFile(contentProvider, null);
InspectorTest.uiSourceCodes[url] = uiSourceCode;
if (!doNotSetSourceMapping) {
breakpointManager._debuggerWorkspaceBinding.setSourceMapping(target.debuggerModel, uiSourceCode, breakpointManager.defaultMapping);

Powered by Google App Engine
This is Rietveld 408576698