third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js - Issue 2893073002: DevTools: introduce ResourceMapping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js

Issue 2893073002: DevTools: introduce ResourceMapping (Closed)

Patch Set: cleanup test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/BUILD.gn ('k') | third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js b/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js

index f0278e20d4ea23da65b02ff4a73ec8cf2848d955..c4174ad005a632c269a70a97cbf0658918f499e1 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js

@@ -140,6 +140,7 @@ Bindings.CSSWorkspaceBinding.ModelInfo = class {

* @param {!Workspace.Workspace} workspace

constructor(cssModel, workspace) {

+ this._target = cssModel.target();

this._eventListeners = [

cssModel.addEventListener(SDK.CSSModel.Events.StyleSheetAdded, this._styleSheetAdded, this),

cssModel.addEventListener(SDK.CSSModel.Events.StyleSheetRemoved, this._styleSheetRemoved, this)

@@ -229,7 +230,11 @@ Bindings.CSSWorkspaceBinding.ModelInfo = class {

var uiLocation = null;

uiLocation = uiLocation || this._sassSourceMapping.rawLocationToUILocation(rawLocation);

uiLocation = uiLocation || this._stylesSourceMapping.rawLocationToUILocation(rawLocation);

- return uiLocation;

+ if (uiLocation)

+ return uiLocation;

+ var resourceBinding = Bindings.ResourceBinding.forTarget(this._target);

+ var uiSourceCode = resourceBinding ? resourceBinding.uiSourceCodeForURL(rawLocation.url) : null;

dgozman 2017/05/19 23:51:05 Bindings.ResourceBinding.uiSourceCodeForURL(this._

lushnikov 2017/06/09 01:29:07 Done.

+ return uiSourceCode ? uiSourceCode.uiLocation(rawLocation.lineNumber, rawLocation.columnNumber) : null;

}

/**