DevTools: introduce ResourceMapping

DevTools: introduce ResourceMapping

This patch splits out ResourceMapping from NetworkProject.
ResourceMapping creates UISourceCodes for resources which are not
handled by CSS Mappings and JS Mappings, such as images, fonts and html
documents.

ResourceMapping is structured like this:
- class ResourceMapping provides uiLocation to rawLocation mapping
  for both CSSWorkspaceBinding and DebuggerWorkspaceBinding. ResourceMapping observes
  resourceTreeModels and creates ModelInfo for each.
- class ResourceMaping.ModelInfo is created per resourceTreeModel to
  manage model-associated UISourceCodes
- class ResourceMapping.Binding binds UISourceCode to multiple
  identical resources

IMPORTANT: The new ResourceMapping also merges UISourceCodes across
frames.

NOTE: Because there are inline scripts and inline styles, HTML UISourceCodes are
needed by both CSSWorkspaceBinding and DebuggerWorkspaceBinding to
implement rawLocationToUILocation / uiLocationToRawLocation methods. Both
CSSWorkspaceBinding and DebuggerWorkspaceBinding refer to ResourceMapping
for this reason.

R=dgozman
BUG=670180
Review-Url: https://codereview.chromium.org/2893073002
Cr-Commit-Position: refs/heads/master@{#478891}
Committed: https://chromium.googlesource.com/chromium/src/+/19a7ba263cc0eff46ac4752bbd04e12bb4f3dc31

[lushnikov, 2017-05-19 19:44:13]

please, take a look

The ResourceBinding suggests the approach which we will use in CSS and JS
bindings.
(Despite having +300 lines, it doesn't happen much here.)

[lushnikov, 2017-05-19 22:36:08]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 22:36:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-05-19 23:51:05]

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:236:
var uiSourceCode = resourceBinding ?
resourceBinding.uiSourceCodeForURL(rawLocation.url) : null;
Bindings.ResourceBinding.uiSourceCodeForURL(this._target, rawLocation.url)

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
(right):

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js:397:
this._workspaceProjects.clear();
Let's do this in _dispose as well.

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:7: *
@unrestricted
restrict it!

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:42:
this._resourceModel = resourceModel;
this._resourceTreeModel

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:63:
static forTarget(target) {
private

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
(right):

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:32: *
@unrestricted
Let's do a map to avoid this.

[commit-bot: I haz the power, 2017-05-20 01:57:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 01:57:18]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[lushnikov, 2017-06-09 01:28:47]

Description was changed from

==========
DevTools: introduce ResourceBinding

This patch splits out ResourceBinding from NetworkProject.

IMPORTANT: The new ResourceBinding also merges UISourceCodes across
frames.

ResourceBinding creates UISourceCodes for resources which are not
handled by CSS Mappings and JS Mappings, such as images, fonts and html
documents.

Since there are inline scripts and inline styles, HTML UISourceCodes are
needed by both CSSWorkspaceBinding and DebuggerWorkspaceBinding to
implement rawLocationToUILocation. This patch addresses the need in the
following way:
- CSSWorkspaceBinding falls back to ResourceBinding at the
  last step, after trying both SourceMap mapping (SASSSourceMapping)
  and CSS mapping (StylesSourceMapping).
- DebuggerWorkspaceBinding is structured differently to CSS.
  The ResourceBinding needs to come into play After the Script Mapping
  (ResourceScriptMapping) and *before* the VM Script Mapping
  (DefaultScriptMapping). Since it's really hard to achieve this
  position using the pushSourceMapping/popSourceMapping system, the
  patch puts the ResourceBinding inside ResourceScriptMapping.

R=dgozman
BUG=670180
==========

to

==========
DevTools: introduce ResourceBinding

This patch splits out ResourceBinding from NetworkProject.

IMPORTANT: The new ResourceBinding also merges UISourceCodes across
frames.

ResourceBinding creates UISourceCodes for resources which are not
handled by CSS Mappings and JS Mappings, such as images, fonts and html
documents.

NOTE: Because there are inline scripts and inline styles, HTML UISourceCodes are
needed by both CSSWorkspaceBinding and DebuggerWorkspaceBinding to
implement rawLocationToUILocation / uiLocationToRawLocation methods. Both
CSSWorkspaceBinding and DebuggerWorkspaceBinding refer to ResourceBinding
for this reason.

R=dgozman
BUG=670180
==========

[lushnikov, 2017-06-09 01:29:08]

Please, take another look!

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:236:
var uiSourceCode = resourceBinding ?
resourceBinding.uiSourceCodeForURL(rawLocation.url) : null;
On 2017/05/19 23:51:05, dgozman wrote:
> Bindings.ResourceBinding.uiSourceCodeForURL(this._target, rawLocation.url)

Done.

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
(right):

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js:397:
this._workspaceProjects.clear();
On 2017/05/19 23:51:05, dgozman wrote:
> Let's do this in _dispose as well.

Done.

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:7: *
@unrestricted
On 2017/05/19 23:51:05, dgozman wrote:
> restrict it!

Done.

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:42:
this._resourceModel = resourceModel;
On 2017/05/19 23:51:05, dgozman wrote:
> this._resourceTreeModel

Done.

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:63:
static forTarget(target) {
On 2017/05/19 23:51:05, dgozman wrote:
> private

Killed it.

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
(right):

https://codereview.chromium.org/2893073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:32: *
@unrestricted
On 2017/05/19 23:51:05, dgozman wrote:
> Let's do a map to avoid this.

Done.

[lushnikov, 2017-06-09 07:09:31]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 07:09:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 09:11:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 09:11:34]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lushnikov, 2017-06-09 18:34:28]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 18:35:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 21:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 21:15:46]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-06-12 18:48:50]

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/BUILD.gn (right):

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/BUILD.gn:73:
"front_end/bindings/module.json",
Move it back to be sorted!

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:143:
this._target = cssModel.target();
drop

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:235:
var uiSourceCode =
Bindings.resourceBindingManager.uiSourceCodeForURL(this._target,
rawLocation.url);
cssLocationToUILocation(cssLocation) and jsLocationToUILocation(rawLocation)

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:319:
if
(!Bindings.resourceBindingManager.ownsUISourceCode(this._debuggerModel.target(),
uiSourceCode))
uiLocationToJSLocation

[lushnikov, 2017-06-12 22:05:56]

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/BUILD.gn (right):

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/BUILD.gn:73:
"front_end/bindings/module.json",
On 2017/06/12 18:48:50, dgozman wrote:
> Move it back to be sorted!

Done.

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:143:
this._target = cssModel.target();
On 2017/06/12 18:48:50, dgozman wrote:
> drop

Done.

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:235:
var uiSourceCode =
Bindings.resourceBindingManager.uiSourceCodeForURL(this._target,
rawLocation.url);
On 2017/06/12 18:48:50, dgozman wrote:
> cssLocationToUILocation(cssLocation) and jsLocationToUILocation(rawLocation)

Done.

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:319:
if
(!Bindings.resourceBindingManager.ownsUISourceCode(this._debuggerModel.target(),
uiSourceCode))
On 2017/06/12 18:48:50, dgozman wrote:
> uiLocationToJSLocation

Turns out this is not needed - simply calling
this._debuggerModel.createRawLocationByURL is enough.

[lushnikov, 2017-06-12 22:06:02]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 22:06:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-06-12 23:17:53]

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:232:
uiLocation = uiLocation ||
Bindings.resourceBindingManager.cssLocationToUILocation(rawLocation);
Rename: Bindings.ResourceBingindManager -> Bindings.ResourceBinding

Bindings.ResourceBinding -> Bindings.ResourceBinding.ModelInfo

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:324:
rawLocation || this._debuggerModel.createRawLocationByURL(uiSourceCode.url(),
lineNumber, columnNumber);
dgozman: move this to ResourceBinding

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:8:
Bindings.ResourceBindingManager = class {
Let's drift towards the following naming throughout bindings/ folder:

Bindings.ResourceMapping
Bindings.ResourceMapping.Binding 

Bindings.StyleMapping
Bindings.StyleMapping.Binding = .

Bindings.VMMapping
Bindings.ScriptMapping

Bindings.CSSSourceMapMapping
Bindings.JSSourceMapMapping

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:80: var
binding = resourceTreeModel ? this._modelToBinding.get(resourceTreeModel) :
null;
if (binding)
   binding._resetForTest();

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:85:
Bindings.ResourceBinding = class {
Bindings.ResourceMapping.ModelInfo =

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:110:
uiSourceCodeForURL(url) {
inline

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:148:
resourceFile.addResource(resource);
call this unconditionally

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:160: if
(resourceFile._resources.size === 1) {
if (resourceFile.removeResource(resource))
  this._resourceFiles.delete

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:204:
constructor(project, resource) {
jsdoc

[commit-bot: I haz the power, 2017-06-13 00:37:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 00:37:58]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2017-06-13 00:47:15]

Description was changed from

==========
DevTools: introduce ResourceBinding

This patch splits out ResourceBinding from NetworkProject.

IMPORTANT: The new ResourceBinding also merges UISourceCodes across
frames.

ResourceBinding creates UISourceCodes for resources which are not
handled by CSS Mappings and JS Mappings, such as images, fonts and html
documents.

NOTE: Because there are inline scripts and inline styles, HTML UISourceCodes are
needed by both CSSWorkspaceBinding and DebuggerWorkspaceBinding to
implement rawLocationToUILocation / uiLocationToRawLocation methods. Both
CSSWorkspaceBinding and DebuggerWorkspaceBinding refer to ResourceBinding
for this reason.

R=dgozman
BUG=670180
==========

to

==========
DevTools: introduce ResourceMapping

This patch splits out ResourceMapping from NetworkProject.
ResourceMapping creates UISourceCodes for resources which are not
handled by CSS Mappings and JS Mappings, such as images, fonts and html
documents.

ResourceMapping is structured like this:
- class ResourceMapping provides uiLocation to rawLocation mapping
  for both CSSWorkspaceBinding and DebuggerWorkspaceBinding. ResourceMapping
observes
  resourceTreeModels and creates ModelInfo for each.
- class ResourceMaping.ModelInfo is created per resourceTreeModel to
  manage model-associated UISourceCodes
- class ResourceMapping.Binding binds UISourceCode to multiple
  identical resources

IMPORTANT: The new ResourceMapping also merges UISourceCodes across
frames.

NOTE: Because there are inline scripts and inline styles, HTML UISourceCodes are
needed by both CSSWorkspaceBinding and DebuggerWorkspaceBinding to
implement rawLocationToUILocation / uiLocationToRawLocation methods. Both
CSSWorkspaceBinding and DebuggerWorkspaceBinding refer to ResourceMapping
for this reason.

R=dgozman
BUG=670180
==========

[lushnikov, 2017-06-13 00:49:14]

all done, please take another look!

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:232:
uiLocation = uiLocation ||
Bindings.resourceBindingManager.cssLocationToUILocation(rawLocation);
On 2017/06/12 23:17:53, lushnikov wrote:
> Rename: Bindings.ResourceBingindManager -> Bindings.ResourceBinding
> 
> Bindings.ResourceBinding -> Bindings.ResourceBinding.ModelInfo

Done.

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:324:
rawLocation || this._debuggerModel.createRawLocationByURL(uiSourceCode.url(),
lineNumber, columnNumber);
On 2017/06/12 23:17:53, lushnikov wrote:
> dgozman: move this to ResourceBinding

Done.

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:8:
Bindings.ResourceBindingManager = class {
On 2017/06/12 23:17:53, lushnikov wrote:
> Let's drift towards the following naming throughout bindings/ folder:
> 
> Bindings.ResourceMapping
> Bindings.ResourceMapping.Binding 
> 
> Bindings.StyleMapping
> Bindings.StyleMapping.Binding = .
> 
> Bindings.VMMapping
> Bindings.ScriptMapping
> 
> Bindings.CSSSourceMapMapping
> Bindings.JSSourceMapMapping

Done.

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:80: var
binding = resourceTreeModel ? this._modelToBinding.get(resourceTreeModel) :
null;
On 2017/06/12 23:17:53, lushnikov wrote:
> if (binding)
>    binding._resetForTest();

Done.

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:85:
Bindings.ResourceBinding = class {
On 2017/06/12 23:17:53, lushnikov wrote:
> Bindings.ResourceMapping.ModelInfo =

Done.

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:110:
uiSourceCodeForURL(url) {
On 2017/06/12 23:17:53, lushnikov wrote:
> inline

Done.

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:148:
resourceFile.addResource(resource);
On 2017/06/12 23:17:53, lushnikov wrote:
> call this unconditionally

Kept as-is to be aligned with StylesSOurceMapping

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:160: if
(resourceFile._resources.size === 1) {
On 2017/06/12 23:17:53, lushnikov wrote:
> if (resourceFile.removeResource(resource))
>   this._resourceFiles.delete
>   

Kept as-is to be aligned with StylesSourceMapping

https://codereview.chromium.org/2893073002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js:204:
constructor(project, resource) {
On 2017/06/12 23:17:53, lushnikov wrote:
> jsdoc

Done.

[lushnikov, 2017-06-13 00:49:32]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 00:50:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-06-13 00:58:41]

lgtm

https://codereview.chromium.org/2893073002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:324:
rawLocation || Bindings.resourceMapping.uiLocationToJSLocation(uiSourceCode,
lineNumber, columnNumber);
Call this before default mapping.

https://codereview.chromium.org/2893073002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/bindings/ResourceMapping.js
(right):

https://codereview.chromium.org/2893073002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceMapping.js:82: var
target = Bindings.NetworkProject.targetForUISourceCode(uiSourceCode);
Check that uiSourceCode belongs to ResourceMapping.

[lushnikov, 2017-06-13 01:07:04]

Thanks, all done!

https://codereview.chromium.org/2893073002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
(right):

https://codereview.chromium.org/2893073002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:324:
rawLocation || Bindings.resourceMapping.uiLocationToJSLocation(uiSourceCode,
lineNumber, columnNumber);
On 2017/06/13 00:58:40, dgozman wrote:
> Call this before default mapping.

Done.

https://codereview.chromium.org/2893073002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/bindings/ResourceMapping.js
(right):

https://codereview.chromium.org/2893073002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceMapping.js:82: var
target = Bindings.NetworkProject.targetForUISourceCode(uiSourceCode);
On 2017/06/13 00:58:41, dgozman wrote:
> Check that uiSourceCode belongs to ResourceMapping.

Done.

[lushnikov, 2017-06-13 01:07:13]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-06-13 01:07:14]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2893073002/#ps120001
(title: "address comments")

[commit-bot: I haz the power, 2017-06-13 01:07:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 03:37:06]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1497316033942830,
"parent_rev": "90619b657057559b2a48f62958b7bba5b2c71264", "commit_rev":
"19a7ba263cc0eff46ac4752bbd04e12bb4f3dc31"}

[commit-bot: I haz the power, 2017-06-13 03:37:21]

Description was changed from

==========
DevTools: introduce ResourceMapping

This patch splits out ResourceMapping from NetworkProject.
ResourceMapping creates UISourceCodes for resources which are not
handled by CSS Mappings and JS Mappings, such as images, fonts and html
documents.

ResourceMapping is structured like this:
- class ResourceMapping provides uiLocation to rawLocation mapping
  for both CSSWorkspaceBinding and DebuggerWorkspaceBinding. ResourceMapping
observes
  resourceTreeModels and creates ModelInfo for each.
- class ResourceMaping.ModelInfo is created per resourceTreeModel to
  manage model-associated UISourceCodes
- class ResourceMapping.Binding binds UISourceCode to multiple
  identical resources

IMPORTANT: The new ResourceMapping also merges UISourceCodes across
frames.

NOTE: Because there are inline scripts and inline styles, HTML UISourceCodes are
needed by both CSSWorkspaceBinding and DebuggerWorkspaceBinding to
implement rawLocationToUILocation / uiLocationToRawLocation methods. Both
CSSWorkspaceBinding and DebuggerWorkspaceBinding refer to ResourceMapping
for this reason.

R=dgozman
BUG=670180
==========

to

==========
DevTools: introduce ResourceMapping

This patch splits out ResourceMapping from NetworkProject.
ResourceMapping creates UISourceCodes for resources which are not
handled by CSS Mappings and JS Mappings, such as images, fonts and html
documents.

ResourceMapping is structured like this:
- class ResourceMapping provides uiLocation to rawLocation mapping
  for both CSSWorkspaceBinding and DebuggerWorkspaceBinding. ResourceMapping
observes
  resourceTreeModels and creates ModelInfo for each.
- class ResourceMaping.ModelInfo is created per resourceTreeModel to
  manage model-associated UISourceCodes
- class ResourceMapping.Binding binds UISourceCode to multiple
  identical resources

IMPORTANT: The new ResourceMapping also merges UISourceCodes across
frames.

NOTE: Because there are inline scripts and inline styles, HTML UISourceCodes are
needed by both CSSWorkspaceBinding and DebuggerWorkspaceBinding to
implement rawLocationToUILocation / uiLocationToRawLocation methods. Both
CSSWorkspaceBinding and DebuggerWorkspaceBinding refer to ResourceMapping
for this reason.

R=dgozman
BUG=670180

Review-Url: https://codereview.chromium.org/2893073002
Cr-Commit-Position: refs/heads/master@{#478891}
Committed:
https://chromium.googlesource.com/chromium/src/+/19a7ba263cc0eff46ac4752bbd04...
==========

[commit-bot: I haz the power, 2017-06-13 03:37:23]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/19a7ba263cc0eff46ac4752bbd04...