Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2893013002: Fix DCHECK to include FILLABLE_FORM_AUTOFILLED_NONE_DID_NOT_SHOW_SUGGESTIONS. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by csashi
Modified:
2 months, 1 week ago
Reviewers:
sebsg
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK to include FILLABLE_FORM_AUTOFILLED_NONE_DID_NOT_SHOW_SUGGESTIONS. BUG=722947 Review-Url: https://codereview.chromium.org/2893013002 Cr-Commit-Position: refs/heads/master@{#473280} Committed: https://chromium.googlesource.com/chromium/src/+/21107f7aaf8a03530821e5305a9a49edba1eb034

Patch Set 1 #

Patch Set 2 : Fix DCHECK to include FILLABLE_FORM_AUTOFILLED_NONE_DID_NOT_SHOW_SUGGESTIONS. #

Messages

Total messages: 13 (7 generated)
csashi
Hi Sebastien, Please take a look. Missed this case in the previous 'fix'. Thanks! -sashi.
2 months, 1 week ago (2017-05-19 17:50:32 UTC) #2
sebsg
lgtm
2 months, 1 week ago (2017-05-19 18:06:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893013002/1
2 months, 1 week ago (2017-05-19 18:07:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/215064) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
2 months, 1 week ago (2017-05-19 18:11:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893013002/20001
2 months, 1 week ago (2017-05-19 18:16:25 UTC) #10
commit-bot: I haz the power
2 months, 1 week ago (2017-05-19 19:38:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/21107f7aaf8a03530821e5305a9a...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973