Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: components/autofill/core/browser/autofill_metrics.cc

Issue 2893013002: Fix DCHECK to include FILLABLE_FORM_AUTOFILLED_NONE_DID_NOT_SHOW_SUGGESTIONS. (Closed)
Patch Set: Fix DCHECK to include FILLABLE_FORM_AUTOFILLED_NONE_DID_NOT_SHOW_SUGGESTIONS. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_metrics.cc
diff --git a/components/autofill/core/browser/autofill_metrics.cc b/components/autofill/core/browser/autofill_metrics.cc
index 2f9c996895b6c5782f5a76999f239e3310e90876..8075cff3757823656dfd8964a5d135e5a4e29ce0 100644
--- a/components/autofill/core/browser/autofill_metrics.cc
+++ b/components/autofill/core/browser/autofill_metrics.cc
@@ -1142,7 +1142,9 @@ void AutofillMetrics::FormInteractionsUkmLogger::LogFormSubmitted(
builder->AddMetric(internal::kUKMAutofillFormSubmittedStateMetricName,
static_cast<int>(state));
if (form_parsed_timestamp_.is_null())
- DCHECK_EQ(state, NON_FILLABLE_FORM_OR_NEW_DATA);
+ DCHECK(state == NON_FILLABLE_FORM_OR_NEW_DATA ||
+ state == FILLABLE_FORM_AUTOFILLED_NONE_DID_NOT_SHOW_SUGGESTIONS)
+ << state;
else
builder->AddMetric(internal::kUKMMillisecondsSinceFormParsedMetricName,
MillisecondsSinceFormParsed());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698