Issue 2892943002: Call the parent methods in MessageView::OnPaint, OnFocus, and OnBlur

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2892943002: Call the parent methods in MessageView::OnPaint, OnFocus, and OnBlur (Closed)

Created:
3 years, 7 months ago by Evan Stade

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

Call the parent methods in MessageView::OnPaint, OnFocus, and OnBlur They look necessary because View::OnPaint draws the border, and View::OnFocus fires an accessibility event. BUG=719414 TEST=manual (No issue happens) Review-Url: https://codereview.chromium.org/2868833002 Cr-Original-Commit-Position: refs/heads/master@{#470024} Review-Url: https://codereview.chromium.org/2892943002 . Cr-Commit-Position: refs/branch-heads/3071@{#631} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/2f9033dc07a052636a395a38859585aa623264df

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	ui/message_center/views/message_view.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Evan Stade

3 years, 7 months ago (2017-05-19 15:12:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2f9033dc07a052636a395a38859585aa623264df.