Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2868833002: Call the parent methods in MessageView::OnPaint, OnFocus, and OnBlur (Closed)

Created:
3 years, 7 months ago by yoshiki
Modified:
3 years, 7 months ago
Reviewers:
*Evan Stade
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, yhanada, Eliot Courtney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Call the parent methods in MessageView::OnPaint, OnFocus, and OnBlur They look necessary because View::OnPaint draws the border, and View::OnFocus fires an accessibility event. BUG=719414 TEST=manual (No issue happens) Review-Url: https://codereview.chromium.org/2868833002 Cr-Commit-Position: refs/heads/master@{#470024} Committed: https://chromium.googlesource.com/chromium/src/+/851fadadf0feb3dc4c4d12676a223db4b66a2010

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/message_center/views/message_view.cc View 1 chunk +3 lines, -0 lines 3 comments Download

Messages

Total messages: 14 (10 generated)
yoshiki
Hi Evan, you recently removed them in https://crrev.com/2849523005/. I'm not sure why you removed them, ...
3 years, 7 months ago (2017-05-08 11:22:17 UTC) #6
Evan Stade
Sorry and thanks for fixing. I only removed them because SlideOutView doesn't exist any more, ...
3 years, 7 months ago (2017-05-08 16:16:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868833002/1
3 years, 7 months ago (2017-05-08 17:00:37 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 17:05:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/851fadadf0feb3dc4c4d12676a22...

Powered by Google App Engine
This is Rietveld 408576698