Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1588)

Issue 2892773002: Re-enable modal dialog in iframe tests. (Closed)

Created:
3 years, 7 months ago by dmazzoni
Modified:
3 years, 7 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable modal dialog in iframe tests. They were flaky a while ago, but the underlying flakiness should be fixed now. Also add cross-platform "blink" expectations, which will making catching flakiness even easier with more coverage. BUG=622387 Review-Url: https://codereview.chromium.org/2892773002 Cr-Commit-Position: refs/heads/master@{#473452} Committed: https://chromium.googlesource.com/chromium/src/+/3016414cff4dc6b6520a2812282fb2082e81ae84

Patch Set 1 #

Patch Set 2 : Fix some expectations #

Patch Set 3 : Fix expectation again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M content/test/data/accessibility/html/modal-dialog-in-iframe-closed-expected-android.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
A content/test/data/accessibility/html/modal-dialog-in-iframe-closed-expected-blink.txt View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/modal-dialog-in-iframe-opened-expected-blink.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
dmazzoni
3 years, 7 months ago (2017-05-18 16:58:17 UTC) #3
aboxhall
lgtm
3 years, 7 months ago (2017-05-19 05:15:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892773002/1
3 years, 7 months ago (2017-05-19 05:23:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/431570)
3 years, 7 months ago (2017-05-19 07:17:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892773002/20001
3 years, 7 months ago (2017-05-19 19:59:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/78852)
3 years, 7 months ago (2017-05-19 20:37:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892773002/40001
3 years, 7 months ago (2017-05-20 20:40:12 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-20 21:55:32 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3016414cff4dc6b6520a2812282f...

Powered by Google App Engine
This is Rietveld 408576698