Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Issue 2892773002: Re-enable modal dialog in iframe tests. (Closed)
Patch Set: Fix expectation again Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/test/data/accessibility/html/modal-dialog-in-iframe-closed-expected-android.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/dump_accessibility_tree_browsertest.cc
diff --git a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
index 3e73d71159c88d81bda553dfd6519f0303d4dfd9..3f2e31ff6526438eb57dda375afbc351d7cb4775 100644
--- a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
+++ b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
@@ -1297,22 +1297,13 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
RunHtmlTest(FILE_PATH_LITERAL("modal-dialog-opened.html"));
}
-// Flaky: crbug.com/593846, crbug.com/596514
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
- DISABLED_AccessibilityModalDialogInIframeClosed) {
+ AccessibilityModalDialogInIframeClosed) {
RunHtmlTest(FILE_PATH_LITERAL("modal-dialog-in-iframe-closed.html"));
}
-// Flaky on Windows and Mac: crbug.com/593846
-#if defined(OS_WIN) || defined(OS_MACOSX)
-#define MAYBE_AccessibilityModalDialogInIframeOpened \
- DISABLED_AccessibilityModalDialogInIframeOpened
-#else
-#define MAYBE_AccessibilityModalDialogInIframeOpened \
- AccessibilityModalDialogInIframeOpened
-#endif
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
- MAYBE_AccessibilityModalDialogInIframeOpened) {
+ AccessibilityModalDialogInIframeOpened) {
RunHtmlTest(FILE_PATH_LITERAL("modal-dialog-in-iframe-opened.html"));
}
« no previous file with comments | « no previous file | content/test/data/accessibility/html/modal-dialog-in-iframe-closed-expected-android.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698