build: Remove build system support for gold plugin.

build: Remove build system support for gold plugin.

R=thakis@chromium.org
TBR=mseaborn@chromium.org
BUG=607968
Review-Url: https://codereview.chromium.org/2891513002
Cr-Commit-Position: refs/heads/master@{#472258}
Committed: https://chromium.googlesource.com/chromium/src/+/5d98fe2426808ddc4c9526a49ce63db2ace279c2

[pcc1, 2017-05-16 19:49:49]

The CQ bit was checked by pcc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 19:51:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-05-16 19:52:36]

lgtm!

Current clang roll apparently caused https://crbug.com/722345, but looks like
that doesn't need a revert.

[commit-bot: I haz the power, 2017-05-16 19:57:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 19:57:27]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pcc1, 2017-05-16 20:32:54]

The CQ bit was checked by pcc@chromium.org

[pcc1, 2017-05-16 20:32:55]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2891513002/#ps20001
(title: "Rebase on trunk")

[commit-bot: I haz the power, 2017-05-16 20:35:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pcc1, 2017-05-16 21:03:24]

Description was changed from

==========
build: Remove build system support for gold plugin.

R=thakis@chromium.org
BUG=607968
==========

to

==========
build: Remove build system support for gold plugin.

R=thakis@chromium.org
TBR=mseaborn@chromium.org
BUG=607968
==========

[pcc1, 2017-05-16 21:03:24]

pcc@chromium.org changed reviewers:
+ mseaborn@chromium.org

[commit-bot: I haz the power, 2017-05-17 00:12:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494966774453590,
"parent_rev": "edc6da3999ae141bef700d80b69323849e2290de", "commit_rev":
"5d98fe2426808ddc4c9526a49ce63db2ace279c2"}

[commit-bot: I haz the power, 2017-05-17 00:13:03]

Description was changed from

==========
build: Remove build system support for gold plugin.

R=thakis@chromium.org
TBR=mseaborn@chromium.org
BUG=607968
==========

to

==========
build: Remove build system support for gold plugin.

R=thakis@chromium.org
TBR=mseaborn@chromium.org
BUG=607968

Review-Url: https://codereview.chromium.org/2891513002
Cr-Commit-Position: refs/heads/master@{#472258}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d98fe2426808ddc4c9526a49ce6...
==========

[commit-bot: I haz the power, 2017-05-17 00:13:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5d98fe2426808ddc4c9526a49ce6...

[pcc1, 2017-05-17 18:58:04]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2892643002/ by pcc@chromium.org.

The reason for reverting is: Broke CFI buildbots:

https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20CF
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT

Need build file fixes to make is_cfi imply use_lld..