Lose the user gesture expiration check on IdentifyReferrerChainByWebContents

Lose the user gesture expiration check on IdentifyReferrerChainByWebContents

This change will help better attribute HTML5 File API downloads and crx
extension download case.

BUG=723089
Review-Url: https://codereview.chromium.org/2892483002
Cr-Commit-Position: refs/heads/master@{#472849}
Committed: https://chromium.googlesource.com/chromium/src/+/c72f3c4c940c6ada4e0447bfd2dd5dfdf532fdf1

[Jialiu Lin, 2017-05-16 23:00:53]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 23:03:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 04:21:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 04:21:05]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Jialiu Lin, 2017-05-17 19:36:21]

jialiul@chromium.org changed reviewers:
+ lpz@chromium.org

[Jialiu Lin, 2017-05-17 19:36:21]

Hi lpz@, 
Let me know if you have time to take a look. Nothing urgent. 

Thanks,

[lpz, 2017-05-17 20:22:05]

lgtm

https://codereview.chromium.org/2892483002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
(right):

https://codereview.chromium.org/2892483002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc:259:
if (user_gesture_map_.find(web_contents) != user_gesture_map_.end())
just to confirm my understanding. It's ok to remove the IsEventExpired check
here because we're not worried about having *very* old gestures in this map
(since CleanUpUserGestures is expected to be called every ~2m)?

https://codereview.chromium.org/2892483002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/safe_browsing_navigation_observer_unittest.cc
(right):

https://codereview.chromium.org/2892483002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/safe_browsing_navigation_observer_unittest.cc:252:
base::Time three_minute_ago =
nit: three_minuteS_ago

[Jialiu Lin, 2017-05-17 20:58:24]

Thanks lpz@!

https://codereview.chromium.org/2892483002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
(right):

https://codereview.chromium.org/2892483002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc:259:
if (user_gesture_map_.find(web_contents) != user_gesture_map_.end())
On 2017/05/17 20:22:04, lpz wrote:
> just to confirm my understanding. It's ok to remove the IsEventExpired check
> here because we're not worried about having *very* old gestures in this map
> (since CleanUpUserGestures is expected to be called every ~2m)?

Yes, that's right.

https://codereview.chromium.org/2892483002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/safe_browsing_navigation_observer_unittest.cc
(right):

https://codereview.chromium.org/2892483002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/safe_browsing_navigation_observer_unittest.cc:252:
base::Time three_minute_ago =
On 2017/05/17 20:22:04, lpz wrote:
> nit: three_minuteS_ago

Good catch. Done.

[Jialiu Lin, 2017-05-18 15:05:20]

The CQ bit was checked by jialiul@chromium.org

[Jialiu Lin, 2017-05-18 15:05:20]

The patchset sent to the CQ was uploaded after l-g-t-m from lpz@chromium.org
Link to the patchset: https://codereview.chromium.org/2892483002/#ps20001
(title: "address comments from lpz")

[commit-bot: I haz the power, 2017-05-18 15:06:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 17:05:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495119920392850,
"parent_rev": "1af8c70d0ce0ccc19e3d65b94e7ae8407f9ec5ca", "commit_rev":
"c72f3c4c940c6ada4e0447bfd2dd5dfdf532fdf1"}

[commit-bot: I haz the power, 2017-05-18 17:05:48]

Description was changed from

==========
Lose the user gesture expiration check on IdentifyReferrerChainByWebContents

This change will help better attribute HTML5 File API downloads and crx
extension download case.

BUG=723089
==========

to

==========
Lose the user gesture expiration check on IdentifyReferrerChainByWebContents

This change will help better attribute HTML5 File API downloads and crx
extension download case.

BUG=723089

Review-Url: https://codereview.chromium.org/2892483002
Cr-Commit-Position: refs/heads/master@{#472849}
Committed:
https://chromium.googlesource.com/chromium/src/+/c72f3c4c940c6ada4e0447bfd2dd...
==========

[commit-bot: I haz the power, 2017-05-18 17:05:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c72f3c4c940c6ada4e0447bfd2dd...